Get commit hash from CI if failed to get it from Git #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sullerandras
changed the title
|
@sullerandras Hi, and thanks so much for this PR! I really appreciate your help. |
maxjacobson
added a commit
that referenced
this pull request
Mar 9, 2017
maxjacobson
added a commit
that referenced
this pull request
Mar 9, 2017
|
This is released as v1.0.7 |
johnallen3d
added a commit
to telus-agcg/nib
that referenced
this pull request
Mar 9, 2017
|
I think this still failing if git is not installed in the container, right? |
|
@pabloroz My expectation is that it shouldn't fail when git is not installed. It may print out a warning to that effect, but the reporter should fall back to the values in the CI environment, if available. Please let us know if you're seeing something different. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing the issue that code coverage is not reported correctly when
.gitfolder is not present.Related issues:
command not found: git - #171
Feature - run on Codeship out of the box - #156
CodeClimate::TestReporter::Git doesn't use branch_from_git_or_ci - #115