Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usage instructions #185

Merged
merged 1 commit into from
Apr 4, 2017
Merged

Conversation

dblandin
Copy link
Contributor

@dblandin dblandin commented Apr 4, 2017

Addresses #184

Inline environment variables are only visible to the command they immediately precede. We only require the token while submitting test coverage so this commit moves the token to precede the codeclimate-test-reporter invocation.

@dblandin dblandin requested a review from ABaldwinHunter April 4, 2017 20:31
@dblandin dblandin force-pushed the devon/update-usage-instructions branch from e4ddbaf to d5664ee Compare April 4, 2017 20:32
README.md Outdated
@@ -18,8 +18,8 @@ Please contact hello@codeclimate.com if you need any assistance setting this up.

## Usage

```
CODECLIMATE_REPO_TOKEN=my_token bundle exec rspec && bundle exec codeclimate-test-reporter
```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is console, not bash, IMO. (It's also perfectly valid as sh, not bash ;))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure sure, was trying to go with the best supported syntax highlighting. I'll switch this to console.

Inline environment variables are only visible to the command they
immediately precede. We only require the token while submitting test
coverage so this commit moves the token to precede the
`codeclimate-test-reporter` invocation.
@dblandin dblandin force-pushed the devon/update-usage-instructions branch from d5664ee to aa79257 Compare April 4, 2017 20:35
@dblandin dblandin merged commit 96f4dcc into master Apr 4, 2017
@dblandin dblandin deleted the devon/update-usage-instructions branch April 4, 2017 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants