Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for open-sourced DroneCI #193

Closed
wants to merge 1 commit into from

Conversation

teohm
Copy link

@teohm teohm commented Aug 22, 2017

Open-sourced DroneCI uses a different set of environment variables:
http://readme.drone.io/usage/environment-reference/

This PR adds open-sourced DroneCI support.

We're using a self-hosted DroneCI, and just tested this PR. So far it's working.

Note: Before submit this PR, we also contacted CodeClimate Support. I think our support ticket is still opened, in case you need more context of this PR. 🙏

@dblandin
Copy link
Contributor

Hey @teohm!

Thanks for the PR! I encourage you to check out our new test reporter, which is currently in public beta.

You should be able to add DroneCI env var support by updating these two files:

https://github.com/codeclimate/test-reporter/blob/master/env/ci.go#L30
https://github.com/codeclimate/test-reporter/blob/master/env/git.go#L159

The new test reporter is faster, distributed as a static binary, has support for parallelized CI builds, and will receive ongoing support by the team here. The existing test reporters for ruby, python, php, and javascript are not yet deprecated but they're unofficially in maintenance mode.

Let me know if you have any questions. Thanks!

cc/ @davehenton

@dblandin
Copy link
Contributor

Going to go ahead and close this in favor of codeclimate/test-reporter#215

Thanks @teohm!

@dblandin dblandin closed this Aug 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants