Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ESLint config to better support external configs #50

Merged
merged 1 commit into from
Dec 7, 2016

Conversation

wfleming
Copy link
Contributor

@wfleming wfleming commented Dec 7, 2016

This should make using codeclimate prepare to use external configs simpler:
I've moved all things that might vary by project into an example base file, and
only keep rules in the two other files (base for all projects, and the ES6
variant to additionally pull in for ES6 projects).

cc @codeclimate/review

@maxjacobson
Copy link
Contributor

I think the javascript/README.md should also be updated - it references eslintrc-es6.js which you've changed the name of in this PR. I think it would be appropriate to explain how we intend for these files to be used in that README as well, potentially

the approach LGTM

@maxjacobson
Copy link
Contributor

Like, instead of:

Periodically, a repo's .eslintrc.js file should be synced with the one here.

Mentioning the new external configuration feature

This should make using `codeclimate prepare` to use external configs simpler:
I've moved all things that might vary by project into an example base file, and
only keep rules in the two other files (base for all projects, and the ES6
variant to additionally pull in for ES6 projects).
@wfleming
Copy link
Contributor Author

wfleming commented Dec 7, 2016

Good point @maxjacobson, updated

@wfleming wfleming merged commit bc5c739 into master Dec 7, 2016
@wfleming wfleming deleted the will/js-refactor branch December 7, 2016 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants