Refactor ESLint config to better support external configs #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfleming
force-pushed
the
will/js-refactor
branch
from
39204c9 to
9586ae4
Compare
|
I think the javascript/README.md should also be updated - it references the approach LGTM |
|
Like, instead of:
Mentioning the new external configuration feature |
This should make using `codeclimate prepare` to use external configs simpler: I've moved all things that might vary by project into an example base file, and only keep rules in the two other files (base for all projects, and the ES6 variant to additionally pull in for ES6 projects).
wfleming
force-pushed
the
will/js-refactor
branch
from
9586ae4 to
15e51af
Compare
|
Good point @maxjacobson, updated |
maxjacobson
approved these changes
Dec 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make using
codeclimate prepareto use external configs simpler:I've moved all things that might vary by project into an example base file, and
only keep rules in the two other files (base for all projects, and the ES6
variant to additionally pull in for ES6 projects).
cc @codeclimate/review