Add shell styleguide #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrisbin
approved these changes
Feb 2, 2017
gdiggs
reviewed
Feb 2, 2017
shell/README.md
Outdated
| features are really needed. | ||
|
|
||
| By the same token, using POSIX flags & functionality that will work between most | ||
| flavors of *nix is preferred when possible. |
There was a problem hiding this comment.
Looks like you need to escape the * here
There was a problem hiding this comment.
I remembered all the underscores & forgot the asterisk. Thanks, fixed.
wfleming
force-pushed
the
will/shell
branch
2 times, most recently
from
5f0ba0b to
3ecb7c4
Compare
We write enough shell that I think it's worth setting out some of our preferences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We write enough shell that I think it's worth setting out some of our preferences.
@pbrisbin I'm sure you have ideas of more to consider here. Are you familiar with any good resources similar to http://www.tldp.org/LDP/abs/html/index.html but more focused on POSIX shell? It would be nice to have something to share with people less familiar with shell scripting that doesn't presume
bashsince we prefer to not usebash-isms unless necessary.