Add rule about spacing #57
Conversation
sass/README.md
Outdated
| Use space between neighboring nested blocks, but not before or after. | ||
|
|
||
| ### Good | ||
| ```scss |
There was a problem hiding this comment.
Please add a space above this block element.
There was a problem hiding this comment.
so fast :)
will do
sass/README.md
Outdated
| color: $green-dark; | ||
| } | ||
| } | ||
|
|
sass/README.md
Outdated
| ``` | ||
|
|
||
| ### Bad | ||
| ```scss |
There was a problem hiding this comment.
Please add a space above this block element.
Inspired by discussion in this PR: https://github.com/codeclimate/app/pull/3973#issuecomment-283774038
ABaldwinHunter
force-pushed
the
abh/scss-spacing
branch
from
a16ed04 to
6cae9dd
Compare
|
@pbrisbin heh naturally :) updated |
sass/README.md
Outdated
|
|
||
| ```scss | ||
| .btn { | ||
| font-size: 15px; |
There was a problem hiding this comment.
💄 should probably sort the rules in all examples since that's what we do in real SCSS.
| } | ||
| ``` | ||
|
|
||
| ### Bad |
There was a problem hiding this comment.
I don't think this 3rd example is needed: the two examples above sufficiently demonstrate the desired style, so this just makes the file longer without much need IMHO.
There was a problem hiding this comment.
I think the third adds to the goldilocks trifecta and there's not much else on this page. Going to leave unless you feel strongly about removing - then let me know!
sass/README.md
Outdated
| @@ -16,3 +16,61 @@ Notable exceptions: | |||
| * prefer double quotes | |||
|
|
|||
| [1]: http://csswizardry.com/2013/01/mindbemding-getting-your-head-round-bem-syntax/ | |||
|
|
|||
| ## whitespace | |||
There was a problem hiding this comment.
💄 capitalize the headline?
|
@ABaldwinHunter Is this PR still active? |
|
Oo yes. Updating and merging |
Inspired by discussion in this PR:
https://github.com/codeclimate/app/pull/3973#issuecomment-283774038