Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop rules #60

Closed
wants to merge 1 commit into from
Closed

Update rubocop rules #60

wants to merge 1 commit into from

Conversation

ABaldwinHunter
Copy link
Contributor

  • Permit no space between one line method defs
  • Allow single line method defs for emtpy methods

Update rubocop rules
708e2f1 
- Permit no space between one line method defs
- Allow single line method defs for emtpy methods
@codeclimate-hermes codeclimate-hermes requested review from wfleming and removed request for codeclimate-hermes September 11, 2017 18:01
@wfleming
Copy link
Contributor

Personally I don't think we want to encourage that style: we see it more in older code, but really we should be avoiding empty method decls everywhere. I think not doing this was a very intentional choice, and we'd be better off cleaning up old code that doesn't adhere.

@ABaldwinHunter
Copy link
Contributor Author

That's a fair point - I was motivated by wanting to compact this class.

which is indeed old code. Will abandon this style change proposal for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wfleming wfleming

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ABaldwinHunter @wfleming