Turn off rubocop's FormatStringToken check #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appeared when we recently upgraded RuboCop: I don't think it's a style we should enforce. The named tokens in format strings can be useful in very complicated cases, but those cases are not the norm, and the check's suggested style makes simple cases *less* readable. In 0.52.0 it also has bugs leading to many false positives where changing the code as suggested would result in incorrect behavior: rubocop/rubocop#5245.
wilson
approved these changes
Dec 18, 2017
gdiggs
approved these changes
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appeared when we recently upgraded RuboCop: I don't think it's a
style we should enforce.
The named tokens in format strings can be useful in very complicated
cases, but those cases are not the norm, and the check's suggested style
makes simple cases less readable.
In 0.52.0 it also has bugs leading to many false positives where
changing the code as suggested would result in incorrect behavior:
rubocop/rubocop#5245. E.g. it wants me to rewrite
time.strftime("%b %d, %l:%M %p")as something liketime.strftime("%<month>b %<day>d, %<hour>l:%<month>M %<ampm>p"), which does not work at all.