Use "indented" style for MultilineMethodCallIndentation

[wfleming]

The current (default) value for this check wants chained assignments to
look like:

foo =
  Foo.
  bar.
  baz

That is not a style I think anybody on our team habitually writes. What
I think we tend to do (and which matches the indented style) is:

foo = Foo.
  bar.
  baz

Since AFAIK this is already the most common de-facto style we use, we
should probably set that in the styleguide.

[kurko]

I don't have strong feelings about either one. LGTM.

I would hope to someday live in a world where the dot is leading not trailing for the reasons thoroughly expressed in standardrb/standard#75

[wfleming]

I would hope to someday live in a world where the dot is leading not trailing for the reasons thoroughly expressed in standardrb/standard#75

@kurko I tend to agree, but because that's a really broad change across the existing code I've been putting if off until we set up an auto-formatter for Ruby, which is a perpetual "hack week?" project.

[bzanchet]

I guess this change had an unintended consequence in the way we indent queries within scopes. The current format matches the indentation on the first example:

  scope :syncable, -> {
    joins(vcs_owner: { vcs_owner_connections: :organization }).
    distinct.
    where.not(status: SYNCINC_STATUSES).
    where("sync_finished_at is null or sync_finished_at < ?", AUTO_SYNC_FREQUENCY.ago).
    merge(Organization.processable).
    order("sync_finished_at NULLS FIRST")
  }

and now rubocop is expecting that same code to look like this:

  scope :syncable, -> {
    joins(vcs_owner: { vcs_owner_connections: :organization }).
      distinct.
      where.not(status: SYNCINC_STATUSES).
      where("sync_finished_at is null or sync_finished_at < ?", AUTO_SYNC_FREQUENCY.ago).
      merge(Organization.processable).
      order("sync_finished_at NULLS FIRST")
  }

while I agree the new rule is better for calling methods, it looks kind of awkward on scopes. Anyway, just FYI.

Ref: https://codeclimate.com/repos/59f12f7da7c8dc02c00011be/pull/11119

hat tip to @filipesperandio who connected the dots.