Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow upload from Travis without token #267

Open
jmcarp opened this issue Nov 30, 2017 · 2 comments
Open

Allow upload from Travis without token #267

jmcarp opened this issue Nov 30, 2017 · 2 comments

Comments

@jmcarp
Copy link

jmcarp commented Nov 30, 2017

Uploading coverage reports requires setting a token in the environment. The documentation recommends skipping coverage uploads on Travis pull request builds, presumably to avoid leaking tokens. But that means it's impossible to get pull request comments on changes in coverage.

Other test coverage products, like codecov, allow uploading from Travis without a token: https://docs.codecov.io/v4.3.6/docs/frequently-asked-questions

The upload token is required for all uploads, except originating from public project using Travis-CI, Circle CI, or AppVeyor CI.

It would be useful to allow coverage uploads from trusted sources to code climate as well.

@ale7714
Copy link
Contributor

ale7714 commented Dec 12, 2017

@jmcarp 👋 thank you for using Code Climate and your feedback. First, wanted to start by saying that's safe to use your CC_TEST_REPORTER_ID directly on your travis file. We only use the ID to identify your repo (more details here).

The reason we were suggesting to avoid uploading results from push builds and PR builds, it's because we were not handling correctly duplicate coverage for the same commit SHA. We recently released a new version of the test-reporter that should handle this scenario correctly. We will also be updating our docs accordingly. Sorry for any confusion.

Let me know if I can help with anything else.

k911 added a commit to k911/swoole-bundle that referenced this issue Mar 16, 2019
According to codeclimate/test-reporter#267 it should be safe to expose
CC_TEST_REPORTER_ID env variable in .travis.yml file
k911 added a commit to k911/swoole-bundle that referenced this issue Mar 16, 2019
According to codeclimate/test-reporter#267 it should be safe to expose
CC_TEST_REPORTER_ID env variable in .travis.yml file
@satanTime
Copy link

+1 here.

if CC_TEST_REPORTER_ID isn't private information I would suggest to share it on the project's page.

I'm a maintainer of an open source project, but, because I don't have admin rights to the repo I cannot fetch the token to finish CI setup, although, I can commit to the repo, release versions etc.

sebk69 pushed a commit to sebk69/openswoole-bundle that referenced this issue Apr 13, 2023
According to codeclimate/test-reporter#267 it should be safe to expose
CC_TEST_REPORTER_ID env variable in .travis.yml file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants