-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow upload from Travis without token #267
Comments
@jmcarp 👋 thank you for using Code Climate and your feedback. First, wanted to start by saying that's safe to use your The reason we were suggesting to avoid uploading results from push builds and PR builds, it's because we were not handling correctly duplicate coverage for the same commit SHA. We recently released a new version of the Let me know if I can help with anything else. |
According to codeclimate/test-reporter#267 it should be safe to expose CC_TEST_REPORTER_ID env variable in .travis.yml file
According to codeclimate/test-reporter#267 it should be safe to expose CC_TEST_REPORTER_ID env variable in .travis.yml file
+1 here. if I'm a maintainer of an open source project, but, because I don't have admin rights to the repo I cannot fetch the token to finish CI setup, although, I can commit to the repo, release versions etc. |
According to codeclimate/test-reporter#267 it should be safe to expose CC_TEST_REPORTER_ID env variable in .travis.yml file
Uploading coverage reports requires setting a token in the environment. The documentation recommends skipping coverage uploads on Travis pull request builds, presumably to avoid leaking tokens. But that means it's impossible to get pull request comments on changes in coverage.
Other test coverage products, like codecov, allow uploading from Travis without a token: https://docs.codecov.io/v4.3.6/docs/frequently-asked-questions
It would be useful to allow coverage uploads from trusted sources to code climate as well.
The text was updated successfully, but these errors were encountered: