Make simplecov json formatter more flexible #488
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplecov_json_formatter
's json report now contains an extra key, namedgroups
. This was included on codeclimate-community/simplecov_json_formatter#2 . The current approach for decoding the JSON report into a predefined struct is too rigid due to the use ofDisallowUnkownFields()
.That explains why the test report will fail to decode the new
simplecov_json_formatter
report, since it has a new keygroups
which is not declared on the struct.This
DisallowUknownFields()
was use as a strategy to detect when the givensimplecov
report is on legacy format (simplecov < 0.18). I'm changing the strategy to extract thesimplecov
version from the test report and make a decision about with simplecov formatter to use based on that.