Fix CI xcode_install_go script #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camillof
requested review from
f-moya and
dantevvp
and removed request for
dantevvp
camillof
commented
Aug 4, 2022
| @@ -9,7 +9,7 @@ linux_image: &linux_image | |||
|
|
|||
| macos_image: &macos_image | |||
| macos: | |||
| xcode: "11.4.0" | |||
| xcode: "11.7.0" | |||
There was a problem hiding this comment.
Current build agent doesn't support 11.4.0 version
f-moya
approved these changes
Aug 4, 2022
This was referenced Aug 4, 2022
Fix release_head_macos and release_head_linux jobs after upgrading xcode base image on CircleCI
#499
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by this comment, I realized CircleCI job
test_macoswasn't running properly. While it was throwing a success message, it wasn't running the tests.See latest master output for this job: https://app.circleci.com/pipelines/github/codeclimate/test-reporter/122/workflows/b88128a1-eaa3-4114-aff8-b0006868438d/jobs/1171/parallel-runs/0/steps/0-103 and compare it with the current fix: https://app.circleci.com/pipelines/github/codeclimate/test-reporter/142/workflows/4b039486-57fd-4850-9011-23285cfe264d/jobs/1219/parallel-runs/0/steps/0-103
Before:
After:
