-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ARM64 version available for building #502
Conversation
@camillof so I'm testing this out on my end but getting the following error:
Gonna try pulling your version and rebuilding locally and see what happens when i try to run that, but if youve run into this before would love to hear what you did to fix it. |
Quick update here. The versions released are for I'll try to get access to a linux arm64 based EC2 instance (Graviton EC2 instance) and try those there. |
To add some extra context that @camillof and I already chatted about offline, it does seem like for what it's worth that the version we currently have up for codeclimate.com/downloads/test-reporter/test-reporter-latest-darwin-amd64 actually works when I run it locally on my M1 mac :/
Haven't actually tried testing it out in terms of running any kind of test coverage locally and using the library but part of me does kinda sorta wonder if we just change the name of the executable if it would magically just "work". |
I created a EC2 graviton arm64 instance for testing:
After copying the binary into the instance, I was able to successfully upload a test report to CC.
From my point of view, this validates that the binary is working correctly on arm64 machines |
@camillof I'm ok with that as well. I'd be curious to publish this package and then once it's up pulling that down and seeing if I can run that locally. But yeah good stuff! |
If everything works well, I'll push another PR to update the README, to publish the arm64 linux versions. |
My guess is that it works because of the "Rosetta" layer on your Mac. I tried using this in the latest CircleCI (which can run on M1 machines) and those machines don't have have Rosetta installed, apparently, because I get this message:
|
Updated Makefile so the ARM64 version of the test-reporter is available to be built.
So far, it has been tested by successfully uploading a test coverage from an Ubuntu arm64 image using this new test-coverage binary.
I also updated the Makefile so the release of this binary is included on new releases. For this, I run the new
build-linux-arm64
command inside acircleci/golang:1.15
container to be sure everything is ok -> The binary was built successfully.Generated ARM64 binary ⬇️
test-reporter-0.10.4-linux-arm64.zip