Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make PathContent's path non-nullable #1174

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

spalmurray-codecov
Copy link
Contributor

Makes PathContent's path attribute non-nullable. Was doing a TS conversion in Gazebo and noticed this was nullable, but upon checking the types in the resolver, path will always be defined.

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review February 25, 2025 18:44
@spalmurray-codecov spalmurray-codecov requested a review from a team as a code owner February 25, 2025 18:44
@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.92%. Comparing base (8ed03b4) to head (8b5f6a8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1174   +/-   ##
=======================================
  Coverage   95.92%   95.92%           
=======================================
  Files         492      492           
  Lines       16876    16876           
=======================================
  Hits        16188    16188           
  Misses        688      688           
Flag Coverage Δ
unit 95.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Feb 25, 2025
Merged via the queue into main with commit f4f7dc8 Feb 25, 2025
28 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/path-is-not-nullable branch February 25, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants