dev: Migrate from pip-compile to uv #1177
Conversation
pyproject.toml
Outdated
| "django-better-admin-arrayfield", | ||
| "django-cors-headers", | ||
| "django-csp", | ||
| "django-cursor-pagination", |
There was a problem hiding this comment.
had to add django-cursor-pagination
There was a problem hiding this comment.
Can we add some versioning for the dependencies that are missing them? We can use some more relaxed versioning (i.e. >=), but it would be best practice to include some sort of version pinning.
There was a problem hiding this comment.
totally agreed, updated to what the requirement.txt file had previously and pinned to the exact version.
In the process also removed opentracing and setproctitle since they looked unused
| @@ -78,7 +78,7 @@ jobs: | |||
| needs: [build-self-hosted, test] | |||
| secrets: inherit | |||
| if: ${{ github.event_name == 'push' && github.event.ref == 'refs/heads/main' && github.repository_owner == 'codecov' }} | |||
| uses: codecov/gha-workflows/.github/workflows/self-hosted.yml@v1.2.27 | |||
| uses: codecov/gha-workflows/.github/workflows/self-hosted.yml@v1.2.33 | |||
| with: | |||
| push_rolling: true | |||
| repo: ${{ vars.CODECOV_IMAGE_V2 || 'codecov/self-hosted-api' }} | |||
There was a problem hiding this comment.
We also might need a cache_file param for this self-hosted workflow to pick the uv.lock file to hash.
There was a problem hiding this comment.
Updated in f9f2257
pyproject.toml
Outdated
| "django-better-admin-arrayfield", | ||
| "django-cors-headers", | ||
| "django-csp", | ||
| "django-cursor-pagination", |
There was a problem hiding this comment.
Can we add some versioning for the dependencies that are missing them? We can use some more relaxed versioning (i.e. >=), but it would be best practice to include some sort of version pinning.
…ile stuff to .ymls
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1177 +/- ##
==========================================
- Coverage 95.89% 95.88% -0.01%
==========================================
Files 494 493 -1
Lines 16887 16869 -18
==========================================
- Hits 16193 16175 -18
Misses 694 694
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
lgtm, I believe one cache_file is missing from the GHA workflow as @michelletran-codecov also mentioned.
Purpose/Motivation
As part of migrating over to umbrella (our future monorepo), we want to make sure everything is on the same package management system for much easier dependency management across each workspace. This PR mimics the changes done in codecov/worker#1098 by updating the Makefile, README, and dockerfiles to support uv in lieu of pip / pip-compile.
I was honestly shocked it basically just worked after that, there were a couple dependency updates I had to do and I also removed ddtrace since I'm pretty sure we use Sentry exclusively for tracing now (confirmed with @trent-codecov) but nothing really other than that so kudos to @michelletran-codecov for a really easy to follow experience 😅
I also removed the opentracing and setproctitle packages since I didn't see any references to those either.
I should probably also double check all the package versions uv installed and pin them to actual versions
Links to relevant tickets
Closes codecov/engineering-team#3371
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.