Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add max age to cookie #1179

Merged
merged 2 commits into from
Feb 28, 2025
Merged

add max age to cookie #1179

merged 2 commits into from
Feb 28, 2025

Conversation

nora-codecov
Copy link
Contributor

This change would cause impersonation to expire after 3 minutes.

@nora-codecov nora-codecov requested a review from a team February 27, 2025 20:00
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (fd87f23) to head (8152625).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1179   +/-   ##
=======================================
  Coverage   95.89%   95.89%           
=======================================
  Files         494      494           
  Lines       16886    16887    +1     
=======================================
+ Hits        16192    16193    +1     
  Misses        694      694           
Flag Coverage Δ
unit 95.89% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you have to reimpersonate every 3 minutes? Or this is like 3 minutes after inactivity?

@matt-codecov
Copy link
Contributor

huge thanks for doing this!

3 minutes might be too aggressive. but if the support team says 3mins is enough for them to do what they need, aggressive is great

@adrian-codecov
Copy link
Contributor

Yeah same thought as Matt, I'd perhaps bump it up a bit, maybe 10 mins? We can always tweak it to more regardless if it feels to short

@nora-codecov
Copy link
Contributor Author

@matt-codecov @adrian-codecov discussed with support team, we will start with 15 min exp 👍

@nora-codecov nora-codecov added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit 9a787d5 Feb 28, 2025
27 of 28 checks passed
@nora-codecov nora-codecov deleted the nora/expire-cookies branch February 28, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants