Improve performance time for ImpactedFiles resolver #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1181 +/- ##
==========================================
- Coverage 95.88% 95.88% -0.01%
==========================================
Files 493 493
Lines 16869 16864 -5
==========================================
- Hits 16175 16170 -5
Misses 694 694
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
JerrySentry
approved these changes
Feb 28, 2025
…ve-impacted-files-resolver-time
…m:codecov/codecov-api into 3397-improve-impacted-files-resolver-time
✅ Sentry found no issues in your recent changes ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
This PR intends to improve loading times in the Pull detail page by adjusting the logic in the
ImpactedFilesresolver.Links to relevant tickets
This is one of the many resolvers I'd like to tackle with the investigation done here.
GH Ticket
What does this PR do?
I'm improving the time it takes to finish the
ImpactedFilesresolver. This resolver is used both in the commit + pull details page, and it needlessly calls the provider every time we get to this page. That's right, we call GH/GL/BB every time you hit any of these pages to display data that doesn't need the provider (there's one part that rightfully requests data, but that's when you unfurl the specific file to see the diff data). This is because we use thehead_reportkey, which always has an "apply_diff" function to it, calling GH in the process.Most of the data displayed in these pages either comes from our DB or from a file stored in GCS. Therefore, I'm adjusting the resolver to use a property that doesn't rely on the data that comes from github, with the caveat that I need to be mindful that I won't need that data, which I dont.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.