Enable timeseries tests, differently #1184
Conversation
Rather than messing with ENV in docker, this uses the test-global `config.yml` to enable timeseries tests, and switches to a lighter-weight timescale docker image.
Swatinem
force-pushed
the
swatinem/test-timeseries
branch
from
a70ffc0 to
bb9cc52
Compare
docker-compose.yml
Outdated
| @@ -39,9 +40,10 @@ services: | |||
| - POSTGRES_PASSWORD=password | |||
| volumes: | |||
| - type: tmpfs | |||
| target: /var/lib/postgresql/data | |||
| target: /home/postgres/pgdata/data | |||
There was a problem hiding this comment.
did an error pop up when you changed the image that caused you to modify this or has this been incorrect the whole time?
There was a problem hiding this comment.
so according to docs, the postgres data is in a different directory from the upstream postgres images, but actually using that for the tmpfs mount errors because of permissions. really weird, but I ended up deleting the volume definition completely.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1184 +/- ##
=======================================
Coverage 95.89% 95.89%
=======================================
Files 494 494
Lines 16887 16887
=======================================
Hits 16193 16193
Misses 694 694
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Rather than messing with ENV in docker, this uses the test-global
config.ymlto enable timeseries tests, and switches to a lighter-weight timescale docker image.