-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: TA tokenless uploads #1187
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #1187 +/- ##
==========================================
- Coverage 95.88% 95.86% -0.02%
==========================================
Files 493 493
Lines 16851 16870 +19
==========================================
+ Hits 16157 16173 +16
- Misses 694 697 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked w/ Shelter's logic and it seems to be aligned. Could you double check thought? Should start at get_token, then should go to tokenless_allowed, and then should go to _tokenless_v2_allowed (and that's the logic that should be on par). This assumes you also accept the newest "true tokenless" method as well btw, so just confirming that's fine too
actually looking at _tokenless_v2_allowed i think this line might also apply to TA, so that's a change we should make alongside this one, to keep things secure |
e632125
to
2d4a7f5
Compare
previously it was broken because it was trying to get the repository and commit information from the request path, when TA requests store that information in the body. So we take the same modifications that the BA tokenless authentication made but change the service to be fetched from the "service" key instead of the "git_service" key
Fixes: codecov/codecov-action#1762