Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Configuration Option to Toggle Access Tab #2227

Merged

Conversation

nicholas-codecov
Copy link
Contributor

@nicholas-codecov nicholas-codecov commented Aug 30, 2023

Description

Currently when running in self hosted mode the access tab on the account settings page is currently hidden, some customers are looking to use this access tab while others are looking to keep it hidden so this is an option that will allow it to be toggled per customer.

Closes #2199

Notable Changes

  • Add check for config.HIDE_ACCESS_TAB in AccountSettings
  • Update tests.

@codecov-staging
Copy link

codecov-staging bot commented Aug 30, 2023

Codecov Report

Merging #2227 (1b88168) into main (5e71473) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2227   +/-   ##
=======================================
  Coverage   97.94%   97.94%           
=======================================
  Files         698      698           
  Lines        7894     7902    +8     
  Branches     1877     1881    +4     
=======================================
+ Hits         7732     7740    +8     
  Misses        160      160           
  Partials        2        2           
Files Changed Coverage
src/config.js 100.00%
src/pages/AccountSettings/AccountSettings.jsx 100.00%
.../pages/AccountSettings/AccountSettingsSideMenu.jsx 100.00%
src/pages/AccountSettings/tabs/Access/Access.jsx 100.00%

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e71473...1b88168. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #2227 (1b88168) into main (5e71473) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2227   +/-   ##
=====================================
  Coverage   97.95   97.95           
=====================================
  Files        698     698           
  Lines       7894    7902    +8     
  Branches    1877    1881    +4     
=====================================
+ Hits        7732    7740    +8     
  Misses       160     160           
  Partials       2       2           
Files Changed Coverage Δ
src/config.js 100.00% <100.00%> (ø)
src/pages/AccountSettings/AccountSettings.jsx 100.00% <100.00%> (ø)
.../pages/AccountSettings/AccountSettingsSideMenu.jsx 100.00% <100.00%> (ø)
src/pages/AccountSettings/tabs/Access/Access.jsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e71473...1b88168. Read the comment docs.

@netlify
Copy link

netlify bot commented Aug 30, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 1b88168
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/64f724758241ee00084faed8
😎 Deploy Preview https://deploy-preview-2227--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Verified

This commit was signed with the committer’s verified signature.
RulaKhaled Rola Abuhasna
… toggle it on

Verified

This commit was signed with the committer’s verified signature.
RulaKhaled Rola Abuhasna

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@nicholas-codecov nicholas-codecov force-pushed the gh-gazebo-2199-add-config-to-toggle-access-tab branch from d03e234 to 0a6f9fe Compare September 5, 2023 11:26

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.

Verified

This commit was signed with the committer’s verified signature.
RulaKhaled Rola Abuhasna
…ed mode
@nicholas-codecov nicholas-codecov merged commit 587ec1e into main Sep 5, 2023
@nicholas-codecov nicholas-codecov deleted the gh-gazebo-2199-add-config-to-toggle-access-tab branch September 5, 2023 16:45
RulaKhaled pushed a commit that referenced this pull request Sep 6, 2023
Allow self hosted users to configure showing/hiding of the access tab under the users account settings.

GH #2199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access to the v5 access token needs to be configurable in yaml
2 participants