Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove F# files from the image blocklist #2428

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Remove F# files from the image blocklist #2428

merged 1 commit into from
Nov 28, 2023
+0 −1

Conversation

drazisil-codecov
Copy link
Contributor

Remove F# files from the image blocklist.

Fixes #2427

@drazisil-codecov
Remove F# files from the image blocklist

Verified

This commit was signed with the committer’s verified signature.
RulaKhaled Rola Abuhasna
GPG key ID: A5E9CDAB9188A2FE
Verified
Learn about vigilant mode
Loading
Loading status checks…
00abfc0 
The .fs extension is not a binary file type

Fixes #2427 2427
@codecov-qa
Copy link

codecov-qa bot commented Nov 28, 2023 •
edited
Loading

Codecov Report

Merging #2428 (00abfc0) into main (429eecf) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2428   +/-   ##
=======================================
  Coverage   97.90%   97.90%           
=======================================
  Files         758      758           
  Lines        9587     9587           
  Branches     2414     2414           
=======================================
  Hits         9386     9386           
  Misses        199      199           
  Partials        2        2
Files Coverage Δ
src/shared/utils/unsupportedExtensionsMapper.js 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 429eecf...00abfc0. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Nov 28, 2023 •
edited
Loading

Codecov Report

Merging #2428 (00abfc0) into main (429eecf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2428   +/-   ##
=======================================
  Coverage   97.90%   97.90%           
=======================================
  Files         758      758           
  Lines        9587     9587           
  Branches     2400     2368   -32     
=======================================
  Hits         9386     9386           
  Misses        199      199           
  Partials        2        2
Files Coverage Δ
src/shared/utils/unsupportedExtensionsMapper.js 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 429eecf...00abfc0. Read the comment docs.

@codecov Codecov
Copy link

codecov bot commented Nov 28, 2023 •
edited
Loading

Codecov Report

Merging #2428 (00abfc0) into main (429eecf) will decrease coverage by 1.80%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2428     +/-   ##
=======================================
- Coverage   97.90   96.10   -1.80     
=======================================
  Files        758     758             
  Lines       9587    9587             
  Branches    2414    2370     -44     
=======================================
- Hits        9386    9213    -173     
- Misses       199     359    +160     
- Partials       2      15     +13
Files Coverage Δ
src/shared/utils/unsupportedExtensionsMapper.js 100.00% <ø> (ø)

... and 25 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 429eecf...00abfc0. Read the comment docs.

@netlify Netlify
Copy link

netlify bot commented Nov 28, 2023

✅ Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 00abfc0
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/6566265cc778a90008b657ab
😎 Deploy Preview https://deploy-preview-2428--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nicholas-codecov
nicholas-codecov approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@drazisil-codecov drazisil-codecov merged commit f691553 into main Nov 28, 2023
@drazisil-codecov drazisil-codecov deleted the drazisil-codecov-patch-1 branch November 28, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholas-codecov nicholas-codecov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FS file extension on the image list in error
2 participants
@drazisil-codecov @nicholas-codecov