Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Remove TOS feature flag #2490

Merged
merged 2 commits into from
Jan 9, 2024
Merged

ref: Remove TOS feature flag #2490

merged 2 commits into from
Jan 9, 2024

Conversation

RulaKhaled
Copy link
Contributor

Description

Getting rid of terms of service feature flag.

closes: #2482

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Verified

This commit was signed with the committer’s verified signature.
RulaKhaled Rola Abuhasna
Copy link

codecov-public-qa bot commented Jan 8, 2024

Codecov Report

Merging #2490 (0640269) into main (3f96e45) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2490      +/-   ##
==========================================
- Coverage   98.23%   98.22%   -0.02%     
==========================================
  Files         776      776              
  Lines        9914     9913       -1     
  Branches     2532     2532              
==========================================
- Hits         9739     9737       -2     
- Misses        173      174       +1     
  Partials        2        2              
Files Coverage Δ
src/layouts/BaseLayout/hooks/useUserAccessGate.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <100.00%> (-0.35%) ⬇️
Pages 99.22% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f96e45...0640269. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2490      +/-   ##
==========================================
- Coverage   98.23%   98.22%   -0.02%     
==========================================
  Files         776      776              
  Lines        9914     9913       -1     
  Branches     2518     2532      +14     
==========================================
- Hits         9739     9737       -2     
- Misses        173      174       +1     
  Partials        2        2              
Files Coverage Δ
src/layouts/BaseLayout/hooks/useUserAccessGate.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <100.00%> (-0.35%) ⬇️
Pages 99.22% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f96e45...0640269. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f96e45) 98.23% compared to head (0640269) 98.22%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2490      +/-   ##
==========================================
- Coverage   98.23%   98.22%   -0.02%     
==========================================
  Files         776      776              
  Lines        9914     9913       -1     
  Branches     2518     2537      +19     
==========================================
- Hits         9739     9737       -2     
- Misses        173      174       +1     
  Partials        2        2              
Files Coverage Δ
src/layouts/BaseLayout/hooks/useUserAccessGate.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <100.00%> (-0.35%) ⬇️
Pages 99.22% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f96e45...0640269. Read the comment docs.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f96e45) 98.23% compared to head (0640269) 98.22%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2490     +/-   ##
=======================================
- Coverage   98.23   98.22   -0.01     
=======================================
  Files        776     776             
  Lines       9914    9913      -1     
  Branches    2518    2532     +14     
=======================================
- Hits        9739    9737      -2     
- Misses       173     174      +1     
  Partials       2       2             
Files Coverage Δ
src/layouts/BaseLayout/hooks/useUserAccessGate.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <100.00%> (-0.35%) ⬇️
Pages 99.22% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f96e45...0640269. Read the comment docs.

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 0640269
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/659d34e1b7ff7f0008a3aa2e
😎 Deploy Preview https://deploy-preview-2490--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RulaKhaled RulaKhaled marked this pull request as ready for review January 8, 2024 14:55

Verified

This commit was signed with the committer’s verified signature.
RulaKhaled Rola Abuhasna
@RulaKhaled RulaKhaled merged commit 2bf7687 into main Jan 9, 2024
@RulaKhaled RulaKhaled deleted the clean-up-feature-flag branch January 9, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up TOS feature flag
2 participants