Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Remove components select feature flag #2491

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

RulaKhaled
Copy link
Contributor

Description

closes: #2483

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Verified

This commit was signed with the committer’s verified signature.
RulaKhaled Rola Abuhasna
@codecov-staging
Copy link

codecov-staging bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2491   +/-   ##
=======================================
  Coverage   98.22%   98.23%           
=======================================
  Files         776      776           
  Lines        9913     9901   -12     
  Branches     2518     2478   -40     
=======================================
- Hits         9737     9726   -11     
+ Misses        174      173    -1     
  Partials        2        2           
Files Coverage Δ
...subRoute/ComponentsSelector/ComponentsSelector.tsx 100.00% <100.00%> (ø)
...lPage/subRoute/FilesChangedTab/FilesChangedTab.tsx 100.00% <ø> (+5.55%) ⬆️
...subroute/ComponentsSelector/ComponentsSelector.tsx 100.00% <100.00%> (ø)
...te/ComponentsMultiSelect/ComponentsMultiSelect.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.23% <100.00%> (+0.01%) ⬆️
Services 99.45% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bf7687...3b7bac9. Read the comment docs.

Copy link

codecov-public-qa bot commented Jan 8, 2024

Codecov Report

Merging #2491 (3b7bac9) into main (2bf7687) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2491   +/-   ##
=======================================
  Coverage   98.22%   98.23%           
=======================================
  Files         776      776           
  Lines        9913     9901   -12     
  Branches     2532     2529    -3     
=======================================
- Hits         9737     9726   -11     
+ Misses        174      173    -1     
  Partials        2        2           
Files Coverage Δ
...subRoute/ComponentsSelector/ComponentsSelector.tsx 100.00% <100.00%> (ø)
...lPage/subRoute/FilesChangedTab/FilesChangedTab.tsx 100.00% <ø> (+5.55%) ⬆️
...subroute/ComponentsSelector/ComponentsSelector.tsx 100.00% <100.00%> (ø)
...te/ComponentsMultiSelect/ComponentsMultiSelect.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.23% <100.00%> (+0.01%) ⬆️
Services 99.45% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bf7687...3b7bac9. Read the comment docs.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2bf7687) 98.22% compared to head (3b7bac9) 98.23%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2491     +/-   ##
=======================================
+ Coverage   98.22   98.23   +0.01     
=======================================
  Files        776     776             
  Lines       9913    9901     -12     
  Branches    2488    2524     +36     
=======================================
- Hits        9737    9726     -11     
+ Misses       174     173      -1     
  Partials       2       2             
Files Coverage Δ
...subRoute/ComponentsSelector/ComponentsSelector.tsx 100.00% <100.00%> (ø)
...lPage/subRoute/FilesChangedTab/FilesChangedTab.tsx 100.00% <ø> (+5.55%) ⬆️
...subroute/ComponentsSelector/ComponentsSelector.tsx 100.00% <100.00%> (ø)
...te/ComponentsMultiSelect/ComponentsMultiSelect.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.23% <100.00%> (+0.01%) ⬆️
Services 99.45% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bf7687...3b7bac9. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2bf7687) 98.22% compared to head (3b7bac9) 98.23%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2491   +/-   ##
=======================================
  Coverage   98.22%   98.23%           
=======================================
  Files         776      776           
  Lines        9913     9901   -12     
  Branches     2488     2529   +41     
=======================================
- Hits         9737     9726   -11     
+ Misses        174      173    -1     
  Partials        2        2           
Files Coverage Δ
...subRoute/ComponentsSelector/ComponentsSelector.tsx 100.00% <100.00%> (ø)
...lPage/subRoute/FilesChangedTab/FilesChangedTab.tsx 100.00% <ø> (+5.55%) ⬆️
...subroute/ComponentsSelector/ComponentsSelector.tsx 100.00% <100.00%> (ø)
...te/ComponentsMultiSelect/ComponentsMultiSelect.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.23% <100.00%> (+0.01%) ⬆️
Services 99.45% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bf7687...3b7bac9. Read the comment docs.

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 3b7bac9
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/659d367ddf06710008314fa0
😎 Deploy Preview https://deploy-preview-2491--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Verified

This commit was signed with the committer’s verified signature.
RulaKhaled Rola Abuhasna
@RulaKhaled RulaKhaled merged commit fd44204 into main Jan 9, 2024
@RulaKhaled RulaKhaled deleted the components-feature-flag branch January 9, 2024 12:29
RulaKhaled added a commit that referenced this pull request Jan 11, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up components feature flag
2 participants