Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Od/chore/casing for git provider #2901

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: change all UI rendered BitBucket to Bitbucket
  • Loading branch information
sashaboi committed May 27, 2024
commit 7a416827476245ec66f74da41fe1328385f51cb6
4 changes: 2 additions & 2 deletions src/pages/SyncProviderPage/SyncButton.spec.tsx
Original file line number Diff line number Diff line change
@@ -38,7 +38,7 @@ describe('SyncButton', () => {
it('renders sync button', () => {
render(<SyncButton provider="bb" />, { wrapper })

const link = screen.getByRole('link', { name: /Sync with BitBucket/ })
const link = screen.getByRole('link', { name: /Sync with Bitbucket/ })

const expectedRedirect = encodeURIComponent('http://localhost/bb')
expect(link).toBeInTheDocument()
@@ -79,7 +79,7 @@ describe('SyncButton', () => {
render(<SyncButton provider="bbs" />, { wrapper })

const link = screen.getByRole('link', {
name: /Sync with BitBucket Server/,
name: /Sync with Bitbucket Server/,
})

const expectedRedirect = encodeURIComponent('http://localhost/bbs')
8 changes: 4 additions & 4 deletions src/shared/utils/provider.js
Original file line number Diff line number Diff line change
@@ -8,17 +8,17 @@ import gitlabLogo from 'assets/providers/gitlab-icon.svg'
export function providerToName(provider, forRender = false) {
return {
gh: forRender ? 'GitHub' : 'Github',
bb: 'BitBucket',
bb: forRender ? 'Bitbucket' : 'BitBucket',
gl: forRender ? 'GitLab' : 'Gitlab',
ghe: forRender ? 'GitHub Enterprise' : 'Github Enterprise',
gle: forRender ? 'GitLab Enterprise' : 'Gitlab Enterprise',
bbs: 'BitBucket Server',
bbs: forRender ? 'Bitbucket Server' : 'BitBucket Server',
github: forRender ? 'GitHub' : 'Github',
bitbucket: 'BitBucket',
bitbucket: forRender ? 'Bitbucket' : 'BitBucket',
gitlab: forRender ? 'GitLab' : 'Gitlab',
github_enterprise: forRender ? 'GitHub Enterprise' : 'Github Enterprise',
gitlab_enterprise: forRender ? 'GitLab Enterprise' : 'Gitlab Enterprise',
bitbucket_server: 'BitBucket Server',
bitbucket_server: forRender ? 'Bitbucket Server' : 'BitBucket Server',
}[provider.toLowerCase()]
}

24 changes: 24 additions & 0 deletions src/shared/utils/provider.spec.js
Original file line number Diff line number Diff line change
@@ -42,6 +42,12 @@ describe('providerToName', () => {
})
})

describe('when called with bb for render', () => {
it('returns Bitbucket', () => {
expect(providerToName('bb', true)).toBe('Bitbucket')
})
})

describe('when called with ghe', () => {
it('returns Github Enterprise', () => {
expect(providerToName('ghe')).toBe('Github Enterprise')
@@ -60,6 +66,12 @@ describe('providerToName', () => {
})
})

describe('when called with bbs for render', () => {
it('returns Bitbucket Server', () => {
expect(providerToName('bbs', true)).toBe('Bitbucket Server')
})
})

describe('when called with Github', () => {
it('returns Github', () => {
expect(providerToName('github')).toBe('Github')
@@ -90,6 +102,12 @@ describe('providerToName', () => {
})
})

describe('when called with BitBucket for render', () => {
it('returns Bitbucket', () => {
expect(providerToName('BitBucket', true)).toBe('Bitbucket')
})
})

describe('when called with github_enterprise', () => {
it('returns Github Enterprise', () => {
expect(providerToName('github_enterprise')).toBe('Github Enterprise')
@@ -115,6 +133,12 @@ describe('providerToName', () => {
expect(providerToName('bitbucket_server')).toBe('BitBucket Server')
})
})

describe('when called with bitbucket_server for render', () => {
it('returns Bitbucket Server', () => {
expect(providerToName('bitbucket_server', true)).toBe('Bitbucket Server')
})
})
})

describe('providerImage', () => {