Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce the "delete account" action #3745

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Swatinem
Copy link
Contributor

This re-introduces the "Delete Account/Organization" action within the account / organization admin.


This builds upon #3742 and adds delete functionality previously removed in #2892.

(React-)Component wise, this uses a similar pattern to the existing EraseRepoModal code.

@Swatinem Swatinem requested a review from a team February 17, 2025 12:21
@Swatinem Swatinem self-assigned this Feb 17, 2025
@codecov-staging
Copy link

codecov-staging bot commented Feb 17, 2025

Bundle Report

Changes will increase total bundle size by 4.05kB (0.03%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.26MB 2.02kB (0.03%) ⬆️
gazebo-staging-esm 6.31MB 2.03kB (0.03%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 16 bytes 573.76kB 0.0%
assets/DeletionCard-legacy.*.js 2.0kB 2.73kB 275.76% ⚠️

Files in assets/DeletionCard-legacy.*.js:

  • ./src/pages/AccountSettings/tabs/DeletionCard/EraseOwnerModal.tsx → Total Size: 1.66kB

  • ./src/pages/AccountSettings/tabs/DeletionCard/DeletionCard.tsx → Total Size: 2.06kB

view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js -5 bytes 5.51kB -0.09%
assets/index.*.js 5 bytes 10.52kB 0.05%
assets/index.*.js 18 bytes 491.55kB 0.0%
assets/index.*.js -5 bytes 18.53kB -0.03%
assets/DeletionCard.*.js 2.02kB 2.65kB 317.14% ⚠️

Files in assets/DeletionCard.*.js:

  • ./src/pages/AccountSettings/tabs/DeletionCard/DeletionCard.tsx → Total Size: 2.06kB

  • ./src/pages/AccountSettings/tabs/DeletionCard/EraseOwnerModal.tsx → Total Size: 1.66kB

Copy link

codecov bot commented Feb 17, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
4812 2 4810 2
View the top 2 failed test(s) by shortest run time
src/pages/AccountSettings/tabs/DeletionCard/DeletionCard.test.tsx > src/pages/AccountSettings/tabs/DeletionCard/DeletionCard.test.tsx
Stack Traces | 0s run time
Error: Failed to resolve import "services/account" from ".../tabs/DeletionCard/DeletionCard.tsx". Does the file exist?
  Plugin: vite:import-analysis
  File: /home/runner/work/gazebo/gazebo/.../tabs/DeletionCard/DeletionCard.tsx:5:32
  414|  import { useParams } from "react-router-dom";
  415|  import Card from "old_ui/Card";
  416|  import { useEraseAccount } from "services/account";
     |                                   ^
  417|  import Button from "ui/Button";
  418|  import EraseOwnerModal from "./EraseOwnerModal";
 ❯ TransformPluginContext._formatError .../node/chunks/dep-CHZK6zbr.js:49257:41TransformPluginContext.error .../node/chunks/dep-CHZK6zbr.js:49252:16normalizeUrl .../node/chunks/dep-CHZK6zbr.js:64199:23
 ❯ .../node/chunks/dep-CHZK6zbr.js:64331:39TransformPluginContext.transform .../node/chunks/dep-CHZK6zbr.js:64258:7PluginContainer.transform .../node/chunks/dep-CHZK6zbr.js:49098:18loadAndTransform .../node/chunks/dep-CHZK6zbr.js:51931:27

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { __vitest_rollup_error__: { plugin: 'vite:import-analysis', id: '/home/runner/work/gazebo/gazebo/.../tabs/DeletionCard/DeletionCard.tsx', loc: { file: '/home/runner/work/gazebo/gazebo/.../tabs/DeletionCard/DeletionCard.tsx', line: 5, column: 32 }, frame: '414|  import { useParams } from "react-router-dom";\n415|  import Card from "old_ui/Card";\n416|  import { useEraseAccount } from "services/account";\n   |                                   ^\n417|  import Button from "ui/Button";\n418|  import EraseOwnerModal from "./EraseOwnerModal";' } }
src/pages/AccountSettings/tabs/Profile/Profile.test.jsx > src/pages/AccountSettings/tabs/Profile/Profile.test.jsx
Stack Traces | 0s run time
Error: Failed to resolve import "services/account" from ".../tabs/DeletionCard/DeletionCard.tsx". Does the file exist?
  Plugin: vite:import-analysis
  File: /home/runner/work/gazebo/gazebo/.../tabs/DeletionCard/DeletionCard.tsx:5:32
  414|  import { useParams } from "react-router-dom";
  415|  import Card from "old_ui/Card";
  416|  import { useEraseAccount } from "services/account";
     |                                   ^
  417|  import Button from "ui/Button";
  418|  import EraseOwnerModal from "./EraseOwnerModal";
 ❯ TransformPluginContext._formatError .../node/chunks/dep-CHZK6zbr.js:49257:41TransformPluginContext.error .../node/chunks/dep-CHZK6zbr.js:49252:16normalizeUrl .../node/chunks/dep-CHZK6zbr.js:64199:23
 ❯ .../node/chunks/dep-CHZK6zbr.js:64331:39TransformPluginContext.transform .../node/chunks/dep-CHZK6zbr.js:64258:7PluginContainer.transform .../node/chunks/dep-CHZK6zbr.js:49098:18loadAndTransform .../node/chunks/dep-CHZK6zbr.js:51931:27

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { __vitest_rollup_error__: { plugin: 'vite:import-analysis', id: '/home/runner/work/gazebo/gazebo/.../tabs/DeletionCard/DeletionCard.tsx', loc: { file: '/home/runner/work/gazebo/gazebo/.../tabs/DeletionCard/DeletionCard.tsx', line: 5, column: 32 }, frame: '414|  import { useParams } from "react-router-dom";\n415|  import Card from "old_ui/Card";\n416|  import { useEraseAccount } from "services/account";\n   |                                   ^\n417|  import Button from "ui/Button";\n418|  import EraseOwnerModal from "./EraseOwnerModal";' } }

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@codecov-qa
Copy link

codecov-qa bot commented Feb 17, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
4812 2 4810 2
View the top 2 failed test(s) by shortest run time
src/pages/AccountSettings/tabs/DeletionCard/DeletionCard.test.tsx > src/pages/AccountSettings/tabs/DeletionCard/DeletionCard.test.tsx
Stack Traces | 0s run time
Error: Failed to resolve import "services/account" from ".../tabs/DeletionCard/DeletionCard.tsx". Does the file exist?
  Plugin: vite:import-analysis
  File: /home/runner/work/gazebo/gazebo/.../tabs/DeletionCard/DeletionCard.tsx:5:32
  414|  import { useParams } from "react-router-dom";
  415|  import Card from "old_ui/Card";
  416|  import { useEraseAccount } from "services/account";
     |                                   ^
  417|  import Button from "ui/Button";
  418|  import EraseOwnerModal from "./EraseOwnerModal";
 ❯ TransformPluginContext._formatError .../node/chunks/dep-CHZK6zbr.js:49257:41TransformPluginContext.error .../node/chunks/dep-CHZK6zbr.js:49252:16normalizeUrl .../node/chunks/dep-CHZK6zbr.js:64199:23
 ❯ .../node/chunks/dep-CHZK6zbr.js:64331:39TransformPluginContext.transform .../node/chunks/dep-CHZK6zbr.js:64258:7PluginContainer.transform .../node/chunks/dep-CHZK6zbr.js:49098:18loadAndTransform .../node/chunks/dep-CHZK6zbr.js:51931:27

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { __vitest_rollup_error__: { plugin: 'vite:import-analysis', id: '/home/runner/work/gazebo/gazebo/.../tabs/DeletionCard/DeletionCard.tsx', loc: { file: '/home/runner/work/gazebo/gazebo/.../tabs/DeletionCard/DeletionCard.tsx', line: 5, column: 32 }, frame: '414|  import { useParams } from "react-router-dom";\n415|  import Card from "old_ui/Card";\n416|  import { useEraseAccount } from "services/account";\n   |                                   ^\n417|  import Button from "ui/Button";\n418|  import EraseOwnerModal from "./EraseOwnerModal";' } }
src/pages/AccountSettings/tabs/Profile/Profile.test.jsx > src/pages/AccountSettings/tabs/Profile/Profile.test.jsx
Stack Traces | 0s run time
Error: Failed to resolve import "services/account" from ".../tabs/DeletionCard/DeletionCard.tsx". Does the file exist?
  Plugin: vite:import-analysis
  File: /home/runner/work/gazebo/gazebo/.../tabs/DeletionCard/DeletionCard.tsx:5:32
  414|  import { useParams } from "react-router-dom";
  415|  import Card from "old_ui/Card";
  416|  import { useEraseAccount } from "services/account";
     |                                   ^
  417|  import Button from "ui/Button";
  418|  import EraseOwnerModal from "./EraseOwnerModal";
 ❯ TransformPluginContext._formatError .../node/chunks/dep-CHZK6zbr.js:49257:41TransformPluginContext.error .../node/chunks/dep-CHZK6zbr.js:49252:16normalizeUrl .../node/chunks/dep-CHZK6zbr.js:64199:23
 ❯ .../node/chunks/dep-CHZK6zbr.js:64331:39TransformPluginContext.transform .../node/chunks/dep-CHZK6zbr.js:64258:7PluginContainer.transform .../node/chunks/dep-CHZK6zbr.js:49098:18loadAndTransform .../node/chunks/dep-CHZK6zbr.js:51931:27

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { __vitest_rollup_error__: { plugin: 'vite:import-analysis', id: '/home/runner/work/gazebo/gazebo/.../tabs/DeletionCard/DeletionCard.tsx', loc: { file: '/home/runner/work/gazebo/gazebo/.../tabs/DeletionCard/DeletionCard.tsx', line: 5, column: 32 }, frame: '414|  import { useParams } from "react-router-dom";\n415|  import Card from "old_ui/Card";\n416|  import { useEraseAccount } from "services/account";\n   |                                   ^\n417|  import Button from "ui/Button";\n418|  import EraseOwnerModal from "./EraseOwnerModal";' } }

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link

codecov bot commented Feb 17, 2025

Bundle Report

Changes will increase total bundle size by 4.05kB (0.03%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.26MB 2.02kB (0.03%) ⬆️
gazebo-production-esm 6.31MB 2.03kB (0.03%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 16 bytes 573.76kB 0.0%
assets/DeletionCard-legacy.*.js 2.0kB 2.73kB 275.76% ⚠️

Files in assets/DeletionCard-legacy.*.js:

  • ./src/pages/AccountSettings/tabs/DeletionCard/EraseOwnerModal.tsx → Total Size: 1.66kB

  • ./src/pages/AccountSettings/tabs/DeletionCard/DeletionCard.tsx → Total Size: 2.06kB

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js -5 bytes 18.53kB -0.03%
assets/index.*.js -5 bytes 5.51kB -0.09%
assets/index.*.js 18 bytes 491.55kB 0.0%
assets/index.*.js 5 bytes 10.52kB 0.05%
assets/DeletionCard.*.js 2.02kB 2.65kB 317.14% ⚠️

Files in assets/DeletionCard.*.js:

  • ./src/pages/AccountSettings/tabs/DeletionCard/DeletionCard.tsx → Total Size: 2.06kB

  • ./src/pages/AccountSettings/tabs/DeletionCard/EraseOwnerModal.tsx → Total Size: 1.66kB

@codecov-staging
Copy link

codecov-staging bot commented Feb 17, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
4812 2 4810 2
View the top 2 failed test(s) by shortest run time
src/pages/AccountSettings/tabs/DeletionCard/DeletionCard.test.tsx > src/pages/AccountSettings/tabs/DeletionCard/DeletionCard.test.tsx
Stack Traces | 0s run time
Error: Failed to resolve import "services/account" from ".../tabs/DeletionCard/DeletionCard.tsx". Does the file exist?
  Plugin: vite:import-analysis
  File: /home/runner/work/gazebo/gazebo/.../tabs/DeletionCard/DeletionCard.tsx:5:32
  414|  import { useParams } from "react-router-dom";
  415|  import Card from "old_ui/Card";
  416|  import { useEraseAccount } from "services/account";
     |                                   ^
  417|  import Button from "ui/Button";
  418|  import EraseOwnerModal from "./EraseOwnerModal";
 ❯ TransformPluginContext._formatError .../node/chunks/dep-CHZK6zbr.js:49257:41TransformPluginContext.error .../node/chunks/dep-CHZK6zbr.js:49252:16normalizeUrl .../node/chunks/dep-CHZK6zbr.js:64199:23
 ❯ .../node/chunks/dep-CHZK6zbr.js:64331:39TransformPluginContext.transform .../node/chunks/dep-CHZK6zbr.js:64258:7PluginContainer.transform .../node/chunks/dep-CHZK6zbr.js:49098:18loadAndTransform .../node/chunks/dep-CHZK6zbr.js:51931:27

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { __vitest_rollup_error__: { plugin: 'vite:import-analysis', id: '/home/runner/work/gazebo/gazebo/.../tabs/DeletionCard/DeletionCard.tsx', loc: { file: '/home/runner/work/gazebo/gazebo/.../tabs/DeletionCard/DeletionCard.tsx', line: 5, column: 32 }, frame: '414|  import { useParams } from "react-router-dom";\n415|  import Card from "old_ui/Card";\n416|  import { useEraseAccount } from "services/account";\n   |                                   ^\n417|  import Button from "ui/Button";\n418|  import EraseOwnerModal from "./EraseOwnerModal";' } }
src/pages/AccountSettings/tabs/Profile/Profile.test.jsx > src/pages/AccountSettings/tabs/Profile/Profile.test.jsx
Stack Traces | 0s run time
Error: Failed to resolve import "services/account" from ".../tabs/DeletionCard/DeletionCard.tsx". Does the file exist?
  Plugin: vite:import-analysis
  File: /home/runner/work/gazebo/gazebo/.../tabs/DeletionCard/DeletionCard.tsx:5:32
  414|  import { useParams } from "react-router-dom";
  415|  import Card from "old_ui/Card";
  416|  import { useEraseAccount } from "services/account";
     |                                   ^
  417|  import Button from "ui/Button";
  418|  import EraseOwnerModal from "./EraseOwnerModal";
 ❯ TransformPluginContext._formatError .../node/chunks/dep-CHZK6zbr.js:49257:41TransformPluginContext.error .../node/chunks/dep-CHZK6zbr.js:49252:16normalizeUrl .../node/chunks/dep-CHZK6zbr.js:64199:23
 ❯ .../node/chunks/dep-CHZK6zbr.js:64331:39TransformPluginContext.transform .../node/chunks/dep-CHZK6zbr.js:64258:7PluginContainer.transform .../node/chunks/dep-CHZK6zbr.js:49098:18loadAndTransform .../node/chunks/dep-CHZK6zbr.js:51931:27

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { __vitest_rollup_error__: { plugin: 'vite:import-analysis', id: '/home/runner/work/gazebo/gazebo/.../tabs/DeletionCard/DeletionCard.tsx', loc: { file: '/home/runner/work/gazebo/gazebo/.../tabs/DeletionCard/DeletionCard.tsx', line: 5, column: 32 }, frame: '414|  import { useParams } from "react-router-dom";\n415|  import Card from "old_ui/Card";\n416|  import { useEraseAccount } from "services/account";\n   |                                   ^\n417|  import Button from "ui/Button";\n418|  import EraseOwnerModal from "./EraseOwnerModal";' } }

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link

codecov-public-qa bot commented Feb 17, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
4814 2 4812 0
View the top 2 failed tests by shortest run time
src/pages/AccountSettings/tabs/DeletionCard/DeletionCard.test.tsx > src/pages/AccountSettings/tabs/DeletionCard/DeletionCard.test.tsx
Stack Traces | 0s run time
Error: Failed to resolve import "services/account" from ".../tabs/DeletionCard/DeletionCard.tsx". Does the file exist?
  Plugin: vite:import-analysis
  File: /home/runner/work/gazebo/gazebo/.../tabs/DeletionCard/DeletionCard.tsx:5:32
  414|  import { useParams } from "react-router-dom";
  415|  import Card from "old_ui/Card";
  416|  import { useEraseAccount } from "services/account";
     |                                   ^
  417|  import Button from "ui/Button";
  418|  import EraseOwnerModal from "./EraseOwnerModal";
 ❯ TransformPluginContext._formatError .../node/chunks/dep-CHZK6zbr.js:49257:41TransformPluginContext.error .../node/chunks/dep-CHZK6zbr.js:49252:16normalizeUrl .../node/chunks/dep-CHZK6zbr.js:64199:23
 ❯ .../node/chunks/dep-CHZK6zbr.js:64331:39TransformPluginContext.transform .../node/chunks/dep-CHZK6zbr.js:64258:7PluginContainer.transform .../node/chunks/dep-CHZK6zbr.js:49098:18loadAndTransform .../node/chunks/dep-CHZK6zbr.js:51931:27

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { __vitest_rollup_error__: { plugin: 'vite:import-analysis', id: '/home/runner/work/gazebo/gazebo/.../tabs/DeletionCard/DeletionCard.tsx', loc: { file: '/home/runner/work/gazebo/gazebo/.../tabs/DeletionCard/DeletionCard.tsx', line: 5, column: 32 }, frame: '414|  import { useParams } from "react-router-dom";\n415|  import Card from "old_ui/Card";\n416|  import { useEraseAccount } from "services/account";\n   |                                   ^\n417|  import Button from "ui/Button";\n418|  import EraseOwnerModal from "./EraseOwnerModal";' } }
src/pages/AccountSettings/tabs/Profile/Profile.test.jsx > src/pages/AccountSettings/tabs/Profile/Profile.test.jsx
Stack Traces | 0s run time
Error: Failed to resolve import "services/account" from ".../tabs/DeletionCard/DeletionCard.tsx". Does the file exist?
  Plugin: vite:import-analysis
  File: /home/runner/work/gazebo/gazebo/.../tabs/DeletionCard/DeletionCard.tsx:5:32
  414|  import { useParams } from "react-router-dom";
  415|  import Card from "old_ui/Card";
  416|  import { useEraseAccount } from "services/account";
     |                                   ^
  417|  import Button from "ui/Button";
  418|  import EraseOwnerModal from "./EraseOwnerModal";
 ❯ TransformPluginContext._formatError .../node/chunks/dep-CHZK6zbr.js:49257:41TransformPluginContext.error .../node/chunks/dep-CHZK6zbr.js:49252:16normalizeUrl .../node/chunks/dep-CHZK6zbr.js:64199:23
 ❯ .../node/chunks/dep-CHZK6zbr.js:64331:39TransformPluginContext.transform .../node/chunks/dep-CHZK6zbr.js:64258:7PluginContainer.transform .../node/chunks/dep-CHZK6zbr.js:49098:18loadAndTransform .../node/chunks/dep-CHZK6zbr.js:51931:27

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { __vitest_rollup_error__: { plugin: 'vite:import-analysis', id: '/home/runner/work/gazebo/gazebo/.../tabs/DeletionCard/DeletionCard.tsx', loc: { file: '/home/runner/work/gazebo/gazebo/.../tabs/DeletionCard/DeletionCard.tsx', line: 5, column: 32 }, frame: '414|  import { useParams } from "react-router-dom";\n415|  import Card from "old_ui/Card";\n416|  import { useEraseAccount } from "services/account";\n   |                                   ^\n417|  import Button from "ui/Button";\n418|  import EraseOwnerModal from "./EraseOwnerModal";' } }

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Feb 17, 2025

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
204c534 Mon, 17 Feb 2025 12:26:01 GMT Expired Expired
f61497f Mon, 17 Feb 2025 12:38:12 GMT Cloud Enterprise

Base automatically changed from swatinem/deletioncard to main February 20, 2025 10:06
This re-introduces the "Delete Account/Organization" action within the account / organization admin.
@Swatinem Swatinem force-pushed the swatinem/hookup-deleteowner branch from f61497f to ed8c3c3 Compare February 20, 2025 10:08
@Swatinem Swatinem marked this pull request as ready for review February 20, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants