Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove use of barrel files in services/pull #3753

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR removes the barrel file from services/pull, while updating the imports throughout the app.

Ticket: codecov/engineering-team#3352

Notable Changes

  • Remove index.ts from services/pull
  • Update imports throughout app.

@codecov-staging
Copy link

codecov-staging bot commented Feb 19, 2025

Bundle Report

Changes will decrease total bundle size by 12 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.13MB -6 bytes (-0.0%) ⬇️
gazebo-staging-esm 6.2MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js -6 bytes 125.62kB -0.0%

Files in assets/index.*.js:

  • ./src/pages/PullRequestPage/PullCoverage/Summary/CompareSummary/usePullForCompareSummary.js → Total Size: 1.61kB

  • ./src/pages/PullRequestPage/PullCoverage/routes/IndirectChangesTab/IndirectChangedFiles/hooks/useIndirectChangedFilesTable.ts → Total Size: 3.7kB

  • ./src/pages/PullRequestPage/PullCoverage/routes/FilesChangedTab/FilesChanged/hooks/useImpactedFilesTable.js → Total Size: 3.25kB

  • ./src/pages/PullRequestPage/PullCoverage/routes/IndirectChangesTab/PullFileDiff/PullFileDiff.tsx → Total Size: 3.75kB

  • ./src/pages/PullRequestPage/PullCoverage/routes/FlagsTab/FlagsTab.tsx → Total Size: 4.34kB

  • ./src/pages/PullRequestPage/PullCoverage/routes/ComponentsSelector/ComponentsSelector.tsx → Total Size: 2.55kB

  • ./src/pages/PullRequestPage/PullCoverage/routes/IndirectChangesTab/IndirectChangedFiles/NameColumn/NameColumn.jsx → Total Size: 1.26kB

view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js -6 bytes 113.04kB -0.01%

Files in assets/index-legacy.*.js:

  • ./src/pages/PullRequestPage/PullCoverage/routes/IndirectChangesTab/IndirectChangedFiles/hooks/useIndirectChangedFilesTable.ts → Total Size: 3.7kB

  • ./src/pages/PullRequestPage/PullCoverage/routes/FlagsTab/FlagsTab.tsx → Total Size: 4.34kB

  • ./src/pages/PullRequestPage/PullCoverage/routes/IndirectChangesTab/PullFileDiff/PullFileDiff.tsx → Total Size: 3.75kB

  • ./src/pages/PullRequestPage/PullCoverage/routes/FilesChangedTab/FilesChanged/hooks/useImpactedFilesTable.js → Total Size: 3.25kB

  • ./src/pages/PullRequestPage/PullCoverage/routes/IndirectChangesTab/IndirectChangedFiles/NameColumn/NameColumn.jsx → Total Size: 1.26kB

  • ./src/pages/PullRequestPage/PullCoverage/routes/ComponentsSelector/ComponentsSelector.tsx → Total Size: 2.55kB

  • ./src/pages/PullRequestPage/PullCoverage/Summary/CompareSummary/usePullForCompareSummary.js → Total Size: 1.61kB

Copy link

codecov bot commented Feb 19, 2025

Bundle Report

Changes will decrease total bundle size by 12 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.13MB -6 bytes (-0.0%) ⬇️
gazebo-production-esm 6.2MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js -6 bytes 113.04kB -0.01%

Files in assets/index-legacy.*.js:

  • ./src/pages/PullRequestPage/PullCoverage/routes/IndirectChangesTab/IndirectChangedFiles/hooks/useIndirectChangedFilesTable.ts → Total Size: 3.7kB

  • ./src/pages/PullRequestPage/PullCoverage/routes/IndirectChangesTab/IndirectChangedFiles/NameColumn/NameColumn.jsx → Total Size: 1.26kB

  • ./src/pages/PullRequestPage/PullCoverage/Summary/CompareSummary/usePullForCompareSummary.js → Total Size: 1.61kB

  • ./src/pages/PullRequestPage/PullCoverage/routes/FilesChangedTab/FilesChanged/hooks/useImpactedFilesTable.js → Total Size: 3.25kB

  • ./src/pages/PullRequestPage/PullCoverage/routes/IndirectChangesTab/PullFileDiff/PullFileDiff.tsx → Total Size: 3.75kB

  • ./src/pages/PullRequestPage/PullCoverage/routes/FlagsTab/FlagsTab.tsx → Total Size: 4.34kB

  • ./src/pages/PullRequestPage/PullCoverage/routes/ComponentsSelector/ComponentsSelector.tsx → Total Size: 2.55kB

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js -6 bytes 125.62kB -0.0%

Files in assets/index.*.js:

  • ./src/pages/PullRequestPage/PullCoverage/routes/IndirectChangesTab/IndirectChangedFiles/hooks/useIndirectChangedFilesTable.ts → Total Size: 3.7kB

  • ./src/pages/PullRequestPage/PullCoverage/Summary/CompareSummary/usePullForCompareSummary.js → Total Size: 1.61kB

  • ./src/pages/PullRequestPage/PullCoverage/routes/IndirectChangesTab/IndirectChangedFiles/NameColumn/NameColumn.jsx → Total Size: 1.26kB

  • ./src/pages/PullRequestPage/PullCoverage/routes/ComponentsSelector/ComponentsSelector.tsx → Total Size: 2.55kB

  • ./src/pages/PullRequestPage/PullCoverage/routes/IndirectChangesTab/PullFileDiff/PullFileDiff.tsx → Total Size: 3.75kB

  • ./src/pages/PullRequestPage/PullCoverage/routes/FlagsTab/FlagsTab.tsx → Total Size: 4.34kB

  • ./src/pages/PullRequestPage/PullCoverage/routes/FilesChangedTab/FilesChanged/hooks/useImpactedFilesTable.js → Total Size: 3.25kB

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Feb 19, 2025

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
7a77115 Wed, 19 Feb 2025 19:12:42 GMT Expired Expired
78e600e Thu, 20 Feb 2025 17:17:11 GMT Expired Expired
cb6202b Wed, 26 Feb 2025 18:38:04 GMT Cloud Enterprise

@codecov-notifications
Copy link

codecov-notifications bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3753   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         826      826           
  Lines       14947    14947           
  Branches     4255     4263    +8     
=======================================
  Hits        14758    14758           
  Misses        182      182           
  Partials        7        7           
Files with missing lines Coverage Δ
...Summary/CompareSummary/usePullForCompareSummary.js 100.00% <ø> (ø)
...e/routes/ComponentsSelector/ComponentsSelector.tsx 100.00% <ø> (ø)
...sChangedTab/FilesChanged/NameColumn/NameColumn.jsx 92.30% <ø> (ø)
...gedTab/FilesChanged/hooks/useImpactedFilesTable.js 100.00% <ø> (ø)
...uestPage/PullCoverage/routes/FlagsTab/FlagsTab.tsx 100.00% <ø> (ø)
...Tab/IndirectChangedFiles/NameColumn/NameColumn.jsx 90.00% <ø> (ø)
...ChangedFiles/hooks/useIndirectChangedFilesTable.ts 100.00% <ø> (ø)
...s/IndirectChangesTab/PullFileDiff/PullFileDiff.tsx 94.59% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.30% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf4dff0...cb6202b. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (bf4dff0) to head (cb6202b).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3753   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         826      826           
  Lines       14947    14947           
  Branches     4263     4263           
=======================================
  Hits        14758    14758           
  Misses        182      182           
  Partials        7        7           
Files with missing lines Coverage Δ
...Summary/CompareSummary/usePullForCompareSummary.js 100.00% <ø> (ø)
...e/routes/ComponentsSelector/ComponentsSelector.tsx 100.00% <ø> (ø)
...sChangedTab/FilesChanged/NameColumn/NameColumn.jsx 92.30% <ø> (ø)
...gedTab/FilesChanged/hooks/useImpactedFilesTable.js 100.00% <ø> (ø)
...uestPage/PullCoverage/routes/FlagsTab/FlagsTab.tsx 100.00% <ø> (ø)
...Tab/IndirectChangedFiles/NameColumn/NameColumn.jsx 90.00% <ø> (ø)
...ChangedFiles/hooks/useIndirectChangedFilesTable.ts 100.00% <ø> (ø)
...s/IndirectChangesTab/PullFileDiff/PullFileDiff.tsx 94.59% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.30% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf4dff0...cb6202b. Read the comment docs.

Copy link

codecov-public-qa bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (bf4dff0) to head (cb6202b).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3753   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         826      826           
  Lines       14947    14947           
  Branches     4255     4263    +8     
=======================================
  Hits        14758    14758           
  Misses        182      182           
  Partials        7        7           
Files with missing lines Coverage Δ
...Summary/CompareSummary/usePullForCompareSummary.js 100.00% <ø> (ø)
...e/routes/ComponentsSelector/ComponentsSelector.tsx 100.00% <ø> (ø)
...sChangedTab/FilesChanged/NameColumn/NameColumn.jsx 92.30% <ø> (ø)
...gedTab/FilesChanged/hooks/useImpactedFilesTable.js 100.00% <ø> (ø)
...uestPage/PullCoverage/routes/FlagsTab/FlagsTab.tsx 100.00% <ø> (ø)
...Tab/IndirectChangedFiles/NameColumn/NameColumn.jsx 90.00% <ø> (ø)
...ChangedFiles/hooks/useIndirectChangedFilesTable.ts 100.00% <ø> (ø)
...s/IndirectChangesTab/PullFileDiff/PullFileDiff.tsx 94.59% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.30% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf4dff0...cb6202b. Read the comment docs.

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (bf4dff0) to head (cb6202b).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3753   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         826      826           
  Lines       14947    14947           
  Branches     4263     4263           
=======================================
  Hits        14758    14758           
  Misses        182      182           
  Partials        7        7           
Files with missing lines Coverage Δ
...Summary/CompareSummary/usePullForCompareSummary.js 100.00% <ø> (ø)
...e/routes/ComponentsSelector/ComponentsSelector.tsx 100.00% <ø> (ø)
...sChangedTab/FilesChanged/NameColumn/NameColumn.jsx 92.30% <ø> (ø)
...gedTab/FilesChanged/hooks/useImpactedFilesTable.js 100.00% <ø> (ø)
...uestPage/PullCoverage/routes/FlagsTab/FlagsTab.tsx 100.00% <ø> (ø)
...Tab/IndirectChangedFiles/NameColumn/NameColumn.jsx 90.00% <ø> (ø)
...ChangedFiles/hooks/useIndirectChangedFilesTable.ts 100.00% <ø> (ø)
...s/IndirectChangesTab/PullFileDiff/PullFileDiff.tsx 94.59% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.30% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf4dff0...cb6202b. Read the comment docs.

@calvin-codecov
Copy link
Contributor

One small merge conflict to resolve

@nicholas-codecov nicholas-codecov force-pushed the gh-eng-3352-chore-remove-use-of-barrel-files-in-services-pull branch from 78e600e to cb6202b Compare February 26, 2025 18:32
@nicholas-codecov nicholas-codecov added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit e625f18 Feb 27, 2025
62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-3352-chore-remove-use-of-barrel-files-in-services-pull branch February 27, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants