-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove use of barrel files in services/pull #3753
chore: Remove use of barrel files in services/pull #3753
Conversation
Bundle ReportChanges will decrease total bundle size by 12 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
|
Bundle ReportChanges will decrease total bundle size by 12 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3753 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 826 826
Lines 14947 14947
Branches 4255 4263 +8
=======================================
Hits 14758 14758
Misses 182 182
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3753 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 826 826
Lines 14947 14947
Branches 4263 4263
=======================================
Hits 14758 14758
Misses 182 182
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3753 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 826 826
Lines 14947 14947
Branches 4255 4263 +8
=======================================
Hits 14758 14758
Misses 182 182
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3753 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 826 826
Lines 14947 14947
Branches 4263 4263
=======================================
Hits 14758 14758
Misses 182 182
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
One small merge conflict to resolve |
78e600e
to
cb6202b
Compare
Description
This PR removes the barrel file from
services/pull
, while updating the imports throughout the app.Ticket: codecov/engineering-team#3352
Notable Changes
index.ts
fromservices/pull