fix: Add fixes and new rules to tokenless banner show logic #3764
Conversation
calvin-codecov
force-pushed
the
cy/tokenless_banner_show
branch
from
30298a8 to
8ccdef9
Compare
Bundle ReportChanges will decrease total bundle size by 1.9kB (-0.02%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
|
Bundle ReportChanges will decrease total bundle size by 1.9kB (-0.02%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3764 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 824 826 +2
Lines 14798 14830 +32
Branches 4257 4263 +6
=======================================
+ Hits 14609 14641 +32
Misses 182 182
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3764 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 824 826 +2
Lines 14798 14830 +32
Branches 4257 4255 -2
=======================================
+ Hits 14609 14641 +32
Misses 182 182
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3764 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 824 826 +2
Lines 14786 14818 +32
Branches 4250 4256 +6
=======================================
+ Hits 14597 14629 +32
Misses 182 182
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3764 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 824 826 +2
Lines 14798 14830 +32
Branches 4249 4263 +14
=======================================
+ Hits 14609 14641 +32
Misses 182 182
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
| const hasActiveRepos = ownerData?.hasActiveRepos | ||
| const hasPublicRepos = ownerData?.hasPublicRepos | ||
|
|
||
| if ( | ||
| !tokenlessSection || | ||
| !owner || | ||
| !data || | ||
| !currentUser?.user || | ||
| cameFromOnboarding | ||
| ) | ||
| cameFromOnboarding || | ||
| !hasActiveRepos || | ||
| !hasPublicRepos | ||
| ) { |
There was a problem hiding this comment.
this is the main change of bullet 1
| // we want to show the banners again when this setting is changed | ||
| // even if the user dismissed them in the past | ||
| removeFromLocalStorage(MEMBER_TOKEN_NOT_REQUIRED_BANNER) | ||
| removeFromLocalStorage(ADMIN_TOKEN_NOT_REQUIRED_BANNER) | ||
| removeFromLocalStorage(MEMBER_TOKEN_REQUIRED_BANNER) | ||
| removeFromLocalStorage(ADMIN_TOKEN_REQUIRED_BANNER) | ||
|
|
There was a problem hiding this comment.
main change of bullet 2
src/shared/GlobalTopBanners/TokenlessBanner/TokenlessBanner.tsx
Outdated
Show resolved
Hide resolved
| const parsedData = RequestSchema.safeParse(res?.data) | ||
|
|
||
| if (!parsedData.success) { | ||
| return rejectNetworkError({ |
There was a problem hiding this comment.
can we get a test added for this failure case?
calvin-codecov
force-pushed
the
cy/tokenless_banner_show
branch
from
f47a7c1 to
282dd38
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Description
Closes codecov/engineering-team#3074
Notable Changes
hasActiveReposandhasPublicReposto hide the tokenless banner if an organization does not have any active repos or does not have any public repos (which means only private)Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.