-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Move callingFn from string literals to a shared const #3770
ref: Move callingFn from string literals to a shared const #3770
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3770 +/- ##
==========================================
+ Coverage 98.69% 98.70% +0.01%
==========================================
Files 825 825
Lines 14826 14943 +117
Branches 4242 4250 +8
==========================================
+ Hits 14633 14750 +117
Misses 186 186
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3770 +/- ##
==========================================
+ Coverage 98.69% 98.70% +0.01%
==========================================
Files 825 825
Lines 14826 14943 +117
Branches 4250 4250
==========================================
+ Hits 14633 14750 +117
Misses 186 186
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will decrease total bundle size by 5.47kB (-0.04%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
Files in
Files in
Files in
Files in
Files in
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
Files in
Files in
Files in
Files in
Files in
Files in
Files in
Files in
Files in
Files in
Files in
Files in
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3770 +/- ##
==========================================
+ Coverage 98.69% 98.70% +0.01%
==========================================
Files 825 825
Lines 14826 14943 +117
Branches 4242 4242
==========================================
+ Hits 14633 14750 +117
Misses 186 186
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3770 +/- ##
==========================================
+ Coverage 98.69% 98.70% +0.01%
==========================================
Files 825 825
Lines 14826 14943 +117
Branches 4242 4250 +8
==========================================
+ Hits 14633 14750 +117
Misses 186 186
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will decrease total bundle size by 5.47kB (-0.04%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
Files in
Files in
Files in
Files in
Files in
Files in
view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
Files in
Files in
Files in
Files in
Files in
Files in
Files in
Files in
Files in
Files in
Files in
Files in
Files in
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!!
Description
This PR updates all updated calls to the new
rejectNetworkError
helper to use a shared const for thecallingFn
value.From this suggestion.
Ticket: codecov/engineering-team#3329
Notable Changes
rejectNetworkError
calls to use a shared