fix: Change plan update banner to new alert and refresh seat count #3778

calvin-codecov · 2025-02-26T08:41:51Z

Description

Closes codecov/engineering-team#1794

Code Example

Notable Changes

There are two things that this PR is doing:

Changing the plan updated banner to use the new Alert component we have. The ticket requested for auto refresh of the page so that on upgrade from plan to plan, it shows the latest plan instead of the previous plan. Since this ticket has been filed, we've modified how the plan page renders and it does already show the newly upgraded to plan after upgrade so we do not need a full refresh.
However, even though the plan update occurs when redirected from Stripe back to our plan page, the # of seats displayed in the plan card was not updating correctly in the current plan card. Clicking on "Manage plan" and adding 1 seat to the plan would redirect back to the plan page and still show the old number until manually refreshing the page. By refetching the queries before history.push, we ensure that the query cache is cleared. Running invalidateQueries was not enough.

Screenshots

Initially on free plan:

After Stripe checkout on upgrading to Team plan:

After upgrading number of seats from 2->5:

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

codecov · 2025-02-26T08:44:10Z

Bundle Report

Changes will decrease total bundle size by 121 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-production-system	6.12MB	-59 bytes (-0.0%) ⬇️
gazebo-production-esm	6.19MB	-62 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index.*.js`	-9 bytes	638.72kB	-0.0%
`assets/index.*.js`	-132 bytes	55.01kB	-0.24%
`assets/index.*.js`	79 bytes	27.48kB	0.29%

Files in assets/index.*.js:

./src/pages/PlanPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx → Total Size: 5.17kB
./src/pages/PlanPage/subRoutes/CurrentOrgPlan/InfoMessageStripeCallback/InfoMessageStripeCallback.tsx → Total Size: 614 bytes

Files in assets/index.*.js:

./src/pages/PlanPage/subRoutes/UpgradePlanPage/UpgradeForm/hooks/useUpgradeControls.ts → Total Size: 1.03kB

view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index-legacy.*.js`	79 bytes	24.97kB	0.32%
`assets/index-legacy.*.js`	-6 bytes	717.48kB	-0.0%
`assets/index-legacy.*.js`	-132 bytes	51.96kB	-0.25%

Files in assets/index-legacy.*.js:

./src/pages/PlanPage/subRoutes/UpgradePlanPage/UpgradeForm/hooks/useUpgradeControls.ts → Total Size: 1.03kB

Files in assets/index-legacy.*.js:

./src/pages/PlanPage/subRoutes/CurrentOrgPlan/InfoMessageStripeCallback/InfoMessageStripeCallback.tsx → Total Size: 614 bytes
./src/pages/PlanPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx → Total Size: 5.17kB

codecov-staging · 2025-02-26T08:44:12Z

Bundle Report

Changes will decrease total bundle size by 121 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-staging-system	6.12MB	-59 bytes (-0.0%) ⬇️
gazebo-staging-esm	6.19MB	-62 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index.*.js`	-132 bytes	55.01kB	-0.24%
`assets/index.*.js`	79 bytes	27.48kB	0.29%
`assets/index.*.js`	-9 bytes	638.72kB	-0.0%

Files in assets/index.*.js:

./src/pages/PlanPage/subRoutes/CurrentOrgPlan/InfoMessageStripeCallback/InfoMessageStripeCallback.tsx → Total Size: 614 bytes
./src/pages/PlanPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx → Total Size: 5.17kB

Files in assets/index.*.js:

./src/pages/PlanPage/subRoutes/UpgradePlanPage/UpgradeForm/hooks/useUpgradeControls.ts → Total Size: 1.03kB

view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index-legacy.*.js`	79 bytes	24.97kB	0.32%
`assets/index-legacy.*.js`	-6 bytes	717.48kB	-0.0%
`assets/index-legacy.*.js`	-132 bytes	51.96kB	-0.25%

Files in assets/index-legacy.*.js:

./src/pages/PlanPage/subRoutes/UpgradePlanPage/UpgradeForm/hooks/useUpgradeControls.ts → Total Size: 1.03kB

Files in assets/index-legacy.*.js:

./src/pages/PlanPage/subRoutes/CurrentOrgPlan/InfoMessageStripeCallback/InfoMessageStripeCallback.tsx → Total Size: 614 bytes
./src/pages/PlanPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx → Total Size: 5.17kB

codecov · 2025-02-26T08:44:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (9b029c3) to head (447ee53).

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3778   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         826      826           
  Lines       14948    14948           
  Branches     4265     4265           
=======================================
  Hits        14760    14760           
  Misses        181      181           
  Partials        7        7

Files with missing lines	Coverage Δ
...anPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx	`100.00% <ø> (ø)`
...essageStripeCallback/InfoMessageStripeCallback.tsx	`100.00% <ø> (ø)`
...dePlanPage/UpgradeForm/hooks/useUpgradeControls.ts	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.69% <ø> (ø)`
Pages	`98.31% <100.00%> (ø)`
Services	`99.38% <ø> (ø)`
Shared	`99.12% <ø> (ø)`
UI	`99.07% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b029c3...447ee53. Read the comment docs.

codecov-qa · 2025-02-26T08:44:33Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (9b029c3) to head (447ee53).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3778   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         826      826           
  Lines       14948    14948           
  Branches     4265     4257    -8     
=======================================
  Hits        14760    14760           
  Misses        181      181           
  Partials        7        7

Files with missing lines	Coverage Δ
...anPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx	`100.00% <ø> (ø)`
...essageStripeCallback/InfoMessageStripeCallback.tsx	`100.00% <ø> (ø)`
...dePlanPage/UpgradeForm/hooks/useUpgradeControls.ts	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.69% <ø> (ø)`
Pages	`98.31% <100.00%> (ø)`
Services	`99.38% <ø> (ø)`
Shared	`99.12% <ø> (ø)`
UI	`99.07% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b029c3...447ee53. Read the comment docs.

codecov-public-qa · 2025-02-26T08:44:42Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (9b029c3) to head (447ee53).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3778   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         826      826           
  Lines       14948    14948           
  Branches     4257     4257           
=======================================
  Hits        14760    14760           
  Misses        181      181           
  Partials        7        7

Files with missing lines	Coverage Δ
...anPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx	`100.00% <ø> (ø)`
...essageStripeCallback/InfoMessageStripeCallback.tsx	`100.00% <ø> (ø)`
...dePlanPage/UpgradeForm/hooks/useUpgradeControls.ts	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.69% <ø> (ø)`
Pages	`98.31% <100.00%> (ø)`
Services	`99.38% <ø> (ø)`
Shared	`99.12% <ø> (ø)`
UI	`99.07% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b029c3...447ee53. Read the comment docs.

codecov-staging · 2025-02-26T08:46:45Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3778   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         826      826           
  Lines       14948    14948           
  Branches     4257     4257           
=======================================
  Hits        14760    14760           
  Misses        181      181           
  Partials        7        7

Files with missing lines	Coverage Δ
...anPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx	`100.00% <ø> (ø)`
...essageStripeCallback/InfoMessageStripeCallback.tsx	`100.00% <ø> (ø)`
...dePlanPage/UpgradeForm/hooks/useUpgradeControls.ts	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.69% <ø> (ø)`
Pages	`98.31% <100.00%> (ø)`
Services	`99.38% <ø> (ø)`
Shared	`99.12% <ø> (ø)`
UI	`99.07% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b029c3...447ee53. Read the comment docs.

codecov-releaser · 2025-02-26T08:46:47Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`abfbad7`	Wed, 26 Feb 2025 08:46:47 GMT	Expired	Expired
`62dde55`	Wed, 26 Feb 2025 08:59:08 GMT	Expired	Expired
`1e0b5e7`	Wed, 26 Feb 2025 09:13:22 GMT	Expired	Expired
`0be01f3`	Tue, 04 Mar 2025 07:39:42 GMT	Expired	Expired
`447ee53`	Tue, 04 Mar 2025 19:15:27 GMT	Cloud	Enterprise

fix: Change plan update banner to new alert and update seat count

abfbad7

calvin-codecov added 2 commits February 26, 2025 00:53

test: Fix test

62dde55

Merge branch 'main' into cy/updated_plan_banner

1e0b5e7

calvin-codecov changed the title ~~fix: Change plan update banner to new alert and update seat count~~ fix: Change plan update banner to new alert and refresh seat count Feb 26, 2025

spalmurray-codecov approved these changes Feb 28, 2025

View reviewed changes

calvin-codecov added 2 commits March 3, 2025 23:34

Merge branch 'main' into cy/updated_plan_banner

0be01f3

Merge branch 'main' into cy/updated_plan_banner

447ee53

calvin-codecov added this pull request to the merge queue Mar 4, 2025

Any commits made after this event will not be merged.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Change plan update banner to new alert and refresh seat count #3778

fix: Change plan update banner to new alert and refresh seat count #3778

calvin-codecov commented Feb 26, 2025 •

edited

Loading

codecov bot commented Feb 26, 2025 •

edited

Loading

Assets Changed:

Assets Changed:

codecov-staging bot commented Feb 26, 2025 •

edited

Loading

Assets Changed:

Assets Changed:

codecov bot commented Feb 26, 2025 •

edited

Loading

codecov-qa bot commented Feb 26, 2025 •

edited

Loading

codecov-public-qa bot commented Feb 26, 2025 •

edited

Loading

codecov-staging bot commented Feb 26, 2025 •

edited by codecov-notifications bot

Loading

codecov-releaser commented Feb 26, 2025 •

edited

Loading

fix: Change plan update banner to new alert and refresh seat count #3778

fix: Change plan update banner to new alert and refresh seat count #3778

Conversation

calvin-codecov commented Feb 26, 2025 • edited Loading

Description

Code Example

Notable Changes

Screenshots

Link to Sample Entry

Legal Boilerplate

codecov bot commented Feb 26, 2025 • edited Loading

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Assets Changed:

codecov-staging bot commented Feb 26, 2025 • edited Loading

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Assets Changed:

codecov bot commented Feb 26, 2025 • edited Loading

Codecov Report

codecov-qa bot commented Feb 26, 2025 • edited Loading

Codecov Report

codecov-public-qa bot commented Feb 26, 2025 • edited Loading

Codecov Report

codecov-staging bot commented Feb 26, 2025 • edited by codecov-notifications bot Loading

Codecov Report

codecov-releaser commented Feb 26, 2025 • edited Loading

✅ Deploy preview for gazebo ready!

calvin-codecov commented Feb 26, 2025 •

edited

Loading

codecov bot commented Feb 26, 2025 •

edited

Loading

codecov-staging bot commented Feb 26, 2025 •

edited

Loading

codecov bot commented Feb 26, 2025 •

edited

Loading

codecov-qa bot commented Feb 26, 2025 •

edited

Loading

codecov-public-qa bot commented Feb 26, 2025 •

edited

Loading

codecov-staging bot commented Feb 26, 2025 •

edited by codecov-notifications bot

Loading

codecov-releaser commented Feb 26, 2025 •

edited

Loading