Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove barrel file services/repo/schemas #3779

Merged

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR removes the barrel file from services/repo/schemas, while also updating the respective imports throughout the app.

Ticket: codecov/engineering-team#3352

Notable Changes

  • Remove index.ts from services/repo/schemas
  • Update imports throughout app

Copy link

codecov bot commented Feb 26, 2025

Bundle Report

Changes will increase total bundle size by 6 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-esm 6.2MB 6 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 6 bytes 638.11kB 0.0%

Files in assets/index.*.js:

  • ./src/layouts/BaseLayout/hooks/NavigatorDataQueryOpts.ts → Total Size: 1.64kB

@codecov-staging
Copy link

codecov-staging bot commented Feb 26, 2025

Bundle Report

Changes will increase total bundle size by 6 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-esm 6.2MB 6 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 6 bytes 638.11kB 0.0%

Files in assets/index.*.js:

  • ./src/layouts/BaseLayout/hooks/NavigatorDataQueryOpts.ts → Total Size: 1.64kB

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (e625f18) to head (333098e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3779   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         826      826           
  Lines       14947    14947           
  Branches     4255     4255           
=======================================
  Hits        14758    14758           
  Misses        182      182           
  Partials        7        7           
Files with missing lines Coverage Δ
...layouts/BaseLayout/hooks/NavigatorDataQueryOpts.ts 100.00% <ø> (ø)
...eaderDefault/queries/CommitHeaderDataQueryOpts.tsx 100.00% <ø> (ø)
...aderTeam/queries/CommitHeaderDataTeamQueryOpts.tsx 100.00% <ø> (ø)
...mmitDetailPage/queries/CommitPageDataQueryOpts.tsx 100.00% <ø> (ø)
...er/HeaderDefault/queries/PullHeadDataQueryOpts.tsx 100.00% <ø> (ø)
...r/HeaderTeam/queries/PullHeadDataTeamQueryOpts.tsx 100.00% <ø> (ø)
...onentsTab/queries/ComponentComparisonQueryOpts.tsx 100.00% <ø> (ø)
.../PullRequestPage/queries/PullPageDataQueryOpts.tsx 100.00% <ø> (ø)
...urationStatus/RepoConfigurationStatusQueryOpts.tsx 100.00% <ø> (ø)
.../GeneralTab/queries/RepoForTokensTeamQueryOpts.tsx 100.00% <ø> (ø)
... and 60 more
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.30% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e625f18...333098e. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (e625f18) to head (333098e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3779   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         826      826           
  Lines       14947    14947           
  Branches     4255     4263    +8     
=======================================
  Hits        14758    14758           
  Misses        182      182           
  Partials        7        7           
Files with missing lines Coverage Δ
...layouts/BaseLayout/hooks/NavigatorDataQueryOpts.ts 100.00% <ø> (ø)
...eaderDefault/queries/CommitHeaderDataQueryOpts.tsx 100.00% <ø> (ø)
...aderTeam/queries/CommitHeaderDataTeamQueryOpts.tsx 100.00% <ø> (ø)
...mmitDetailPage/queries/CommitPageDataQueryOpts.tsx 100.00% <ø> (ø)
...er/HeaderDefault/queries/PullHeadDataQueryOpts.tsx 100.00% <ø> (ø)
...r/HeaderTeam/queries/PullHeadDataTeamQueryOpts.tsx 100.00% <ø> (ø)
...onentsTab/queries/ComponentComparisonQueryOpts.tsx 100.00% <ø> (ø)
.../PullRequestPage/queries/PullPageDataQueryOpts.tsx 100.00% <ø> (ø)
...urationStatus/RepoConfigurationStatusQueryOpts.tsx 100.00% <ø> (ø)
.../GeneralTab/queries/RepoForTokensTeamQueryOpts.tsx 100.00% <ø> (ø)
... and 60 more
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.30% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e625f18...333098e. Read the comment docs.

Copy link

codecov-public-qa bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (e625f18) to head (333098e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3779   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         826      826           
  Lines       14947    14947           
  Branches     4263     4255    -8     
=======================================
  Hits        14758    14758           
  Misses        182      182           
  Partials        7        7           
Files with missing lines Coverage Δ
...layouts/BaseLayout/hooks/NavigatorDataQueryOpts.ts 100.00% <ø> (ø)
...eaderDefault/queries/CommitHeaderDataQueryOpts.tsx 100.00% <ø> (ø)
...aderTeam/queries/CommitHeaderDataTeamQueryOpts.tsx 100.00% <ø> (ø)
...mmitDetailPage/queries/CommitPageDataQueryOpts.tsx 100.00% <ø> (ø)
...er/HeaderDefault/queries/PullHeadDataQueryOpts.tsx 100.00% <ø> (ø)
...r/HeaderTeam/queries/PullHeadDataTeamQueryOpts.tsx 100.00% <ø> (ø)
...onentsTab/queries/ComponentComparisonQueryOpts.tsx 100.00% <ø> (ø)
.../PullRequestPage/queries/PullPageDataQueryOpts.tsx 100.00% <ø> (ø)
...urationStatus/RepoConfigurationStatusQueryOpts.tsx 100.00% <ø> (ø)
.../GeneralTab/queries/RepoForTokensTeamQueryOpts.tsx 100.00% <ø> (ø)
... and 60 more
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.30% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e625f18...333098e. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Feb 26, 2025

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
9e9405c Wed, 26 Feb 2025 13:24:01 GMT Expired Expired
333098e Thu, 27 Feb 2025 11:53:47 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Feb 27, 2025
@nicholas-codecov nicholas-codecov removed this pull request from the merge queue due to a manual request Feb 27, 2025
@codecov-notifications
Copy link

codecov-notifications bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3779   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         826      826           
  Lines       14947    14947           
  Branches     4255     4263    +8     
=======================================
  Hits        14758    14758           
  Misses        182      182           
  Partials        7        7           
Files with missing lines Coverage Δ
...layouts/BaseLayout/hooks/NavigatorDataQueryOpts.ts 100.00% <ø> (ø)
...eaderDefault/queries/CommitHeaderDataQueryOpts.tsx 100.00% <ø> (ø)
...aderTeam/queries/CommitHeaderDataTeamQueryOpts.tsx 100.00% <ø> (ø)
...mmitDetailPage/queries/CommitPageDataQueryOpts.tsx 100.00% <ø> (ø)
...er/HeaderDefault/queries/PullHeadDataQueryOpts.tsx 100.00% <ø> (ø)
...r/HeaderTeam/queries/PullHeadDataTeamQueryOpts.tsx 100.00% <ø> (ø)
...onentsTab/queries/ComponentComparisonQueryOpts.tsx 100.00% <ø> (ø)
.../PullRequestPage/queries/PullPageDataQueryOpts.tsx 100.00% <ø> (ø)
...urationStatus/RepoConfigurationStatusQueryOpts.tsx 100.00% <ø> (ø)
.../GeneralTab/queries/RepoForTokensTeamQueryOpts.tsx 100.00% <ø> (ø)
... and 60 more
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.30% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e625f18...333098e. Read the comment docs.

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit c3c615f Feb 27, 2025
62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-3352-remove-barrel-file-services-schemas-repo branch February 27, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants