fix: usesInvoice should hide change plan button on members page #3782
Conversation
Bundle ReportChanges will decrease total bundle size by 118 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3782 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 826 826
Lines 14947 14947
Branches 4255 4265 +10
=======================================
Hits 14758 14758
Misses 182 182
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will decrease total bundle size by 118 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3782 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 826 826
Lines 14947 14947
Branches 4255 4257 +2
=======================================
Hits 14758 14758
Misses 182 182
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3782 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 826 826
Lines 14947 14947
Branches 4255 4257 +2
=======================================
Hits 14758 14758
Misses 182 182
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3782 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 826 826
Lines 14947 14947
Branches 4255 4265 +10
=======================================
Hits 14758 14758
Misses 182 182
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
| function ChangePlanLink({ accountDetails, plan }: ChangePlanLinkProps) { | ||
| const isInvoicedCustomer = | ||
| accountDetails?.subscriptionDetail?.collectionMethod === | ||
| CollectionMethods.INVOICED_CUSTOMER_METHOD || accountDetails?.usesInvoice |
There was a problem hiding this comment.
accountDetails?.usesInvoice is the only code change
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Description
This PR fixes a bug where an org with useInvoices = true is still able to access the "backdoor" to update their plan information via the members page.
We simply add the usesInvoice condition here so that if that value is true we hide the element.
This PR also does some TS conversions and adds a new test
Screenshots
BEFORE
AFTER
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.