Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove the default error for failed tests error banner #3784

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

RulaKhaled
Copy link
Contributor

Description

We shouldn't have a default error for the banner

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Feb 28, 2025

Bundle Report

Changes will decrease total bundle size by 152 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.13MB -67 bytes (-0.0%) ⬇️
gazebo-production-esm 6.2MB -85 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js -85 bytes 48.2kB -0.18%

Files in assets/index.*.js:

  • ./src/pages/RepoPage/FailedTestsTab/FailedTestsPage/FailedTestsErrorBanner/FailedTestsErrorBanner.tsx → Total Size: 4.24kB
view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js -67 bytes 44.63kB -0.15%

Files in assets/index-legacy.*.js:

  • ./src/pages/RepoPage/FailedTestsTab/FailedTestsPage/FailedTestsErrorBanner/FailedTestsErrorBanner.tsx → Total Size: 4.24kB

@RulaKhaled RulaKhaled enabled auto-merge February 28, 2025 15:20
@codecov-staging
Copy link

codecov-staging bot commented Feb 28, 2025

Bundle Report

Changes will decrease total bundle size by 152 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.13MB -67 bytes (-0.0%) ⬇️
gazebo-staging-esm 6.2MB -85 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js -85 bytes 48.2kB -0.18%

Files in assets/index.*.js:

  • ./src/pages/RepoPage/FailedTestsTab/FailedTestsPage/FailedTestsErrorBanner/FailedTestsErrorBanner.tsx → Total Size: 4.24kB
view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js -67 bytes 44.63kB -0.15%

Files in assets/index-legacy.*.js:

  • ./src/pages/RepoPage/FailedTestsTab/FailedTestsPage/FailedTestsErrorBanner/FailedTestsErrorBanner.tsx → Total Size: 4.24kB

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (52909c8) to head (6bfcdc3).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3784   +/-   ##
=======================================
  Coverage   98.73%   98.74%           
=======================================
  Files         826      826           
  Lines       14947    14947           
  Branches     4257     4256    -1     
=======================================
+ Hits        14758    14759    +1     
+ Misses        182      181    -1     
  Partials        7        7           
Files with missing lines Coverage Δ
.../FailedTestsErrorBanner/FailedTestsErrorBanner.tsx 100.00% <100.00%> (+4.00%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.31% <100.00%> (+0.01%) ⬆️
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52909c8...6bfcdc3. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (52909c8) to head (6bfcdc3).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3784   +/-   ##
=======================================
  Coverage   98.73%   98.74%           
=======================================
  Files         826      826           
  Lines       14947    14947           
  Branches     4265     4256    -9     
=======================================
+ Hits        14758    14759    +1     
+ Misses        182      181    -1     
  Partials        7        7           
Files with missing lines Coverage Δ
.../FailedTestsErrorBanner/FailedTestsErrorBanner.tsx 100.00% <100.00%> (+4.00%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.31% <100.00%> (+0.01%) ⬆️
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52909c8...6bfcdc3. Read the comment docs.

@RulaKhaled RulaKhaled added this pull request to the merge queue Feb 28, 2025
@codecov-notifications
Copy link

codecov-notifications bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3784   +/-   ##
=======================================
  Coverage   98.73%   98.74%           
=======================================
  Files         826      826           
  Lines       14947    14947           
  Branches     4265     4256    -9     
=======================================
+ Hits        14758    14759    +1     
+ Misses        182      181    -1     
  Partials        7        7           
Files with missing lines Coverage Δ
.../FailedTestsErrorBanner/FailedTestsErrorBanner.tsx 100.00% <100.00%> (+4.00%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.31% <100.00%> (+0.01%) ⬆️
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52909c8...6bfcdc3. Read the comment docs.

Copy link

codecov-public-qa bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (52909c8) to head (6bfcdc3).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3784   +/-   ##
=======================================
  Coverage   98.73%   98.74%           
=======================================
  Files         826      826           
  Lines       14947    14947           
  Branches     4265     4256    -9     
=======================================
+ Hits        14758    14759    +1     
+ Misses        182      181    -1     
  Partials        7        7           
Files with missing lines Coverage Δ
.../FailedTestsErrorBanner/FailedTestsErrorBanner.tsx 100.00% <100.00%> (+4.00%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.31% <100.00%> (+0.01%) ⬆️
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52909c8...6bfcdc3. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
6bfcdc3 Fri, 28 Feb 2025 15:22:35 GMT Cloud Enterprise

Merged via the queue into main with commit c13213e Feb 28, 2025
62 checks passed
@RulaKhaled RulaKhaled deleted the fix-bug-in-failed-tests branch February 28, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants