Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Profile sunburst chart #3785

Merged
merged 3 commits into from
Feb 28, 2025
Merged

feat: Profile sunburst chart #3785

merged 3 commits into from
Feb 28, 2025

Conversation

nicholas-codecov
Copy link
Contributor

@nicholas-codecov nicholas-codecov commented Feb 28, 2025 •
edited
Loading

Description

This PR quickly adds withProfiler HOC to the SunburstChart so we can start collecting information on it, for comparison against some optimizations that are in the pipeline.

Closes: codecov/engineering-team#3428

@codecov-staging
Copy link

codecov-staging bot commented Feb 28, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 745 bytes (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.13MB 374 bytes (0.01%) ⬆️
gazebo-staging-esm 6.2MB 371 bytes (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 374 bytes 98.62kB 0.38%

Files in assets/index-legacy.*.js:

  • ./src/ui/SunburstChart/SunburstChart.jsx → Total Size: 8.04kB
view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 371 bytes 104.11kB 0.36%

Files in assets/index.*.js:

  • ./src/ui/SunburstChart/SunburstChart.jsx → Total Size: 8.04kB

@codecov Codecov
Copy link

codecov bot commented Feb 28, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 745 bytes (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.13MB 374 bytes (0.01%) ⬆️
gazebo-production-esm 6.2MB 371 bytes (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 371 bytes 104.11kB 0.36%

Files in assets/index.*.js:

  • ./src/ui/SunburstChart/SunburstChart.jsx → Total Size: 8.04kB
view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 374 bytes 98.62kB 0.38%

Files in assets/index-legacy.*.js:

  • ./src/ui/SunburstChart/SunburstChart.jsx → Total Size: 8.04kB

@codecov Codecov
Copy link

codecov bot commented Feb 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (c13213e) to head (f3fd74a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3785   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         826      826           
  Lines       14947    14947           
  Branches     4256     4256           
=======================================
  Hits        14759    14759           
  Misses        181      181           
  Partials        7        7
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.31% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c13213e...f3fd74a. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Feb 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (c13213e) to head (f3fd74a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3785   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         826      826           
  Lines       14947    14947           
  Branches     4264     4256    -8     
=======================================
  Hits        14759    14759           
  Misses        181      181           
  Partials        7        7
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.31% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c13213e...f3fd74a. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Feb 28, 2025 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
cf5aa68 Fri, 28 Feb 2025 16:25:16 GMT Expired Expired
cbe0f20 Fri, 28 Feb 2025 16:37:58 GMT Expired Expired
f3fd74a Fri, 28 Feb 2025 17:48:11 GMT Cloud Enterprise

@codecov-notifications
Copy link

codecov-notifications bot commented Feb 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3785   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         826      826           
  Lines       14947    14947           
  Branches     4256     4264    +8     
=======================================
  Hits        14759    14759           
  Misses        181      181           
  Partials        7        7
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.31% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c13213e...f3fd74a. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Feb 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (c13213e) to head (cbe0f20).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3785   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         826      826           
  Lines       14947    14947           
  Branches     4256     4256           
=======================================
  Hits        14759    14759           
  Misses        181      181           
  Partials        7        7
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.31% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c13213e...cbe0f20. Read the comment docs.

spalmurray-codecov
spalmurray-codecov reviewed Feb 28, 2025
View reviewed changes
src/ui/SunburstChart/SunburstChart.jsx
.padAngle((d) => Math.min((d.x1 - d.x0) / 2, 0.005))
.padRadius(radius * 1.5)
.innerRadius((d) => d.y0 * radius)
.outerRadius((d) => Math.max(d.y0 * radius, d.y1 * radius - 1))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my brain hurts

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit cd34d55 Feb 28, 2025
62 checks passed
@nicholas-codecov nicholas-codecov deleted the feat-profile-sunburst-chart branch February 28, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalmurray-codecov spalmurray-codecov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Profile the sunburst
3 participants
@nicholas-codecov @codecov-releaser @spalmurray-codecov