Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: usePullCompareTotalsTeam parsing error #3786

Merged
merged 1 commit into from
Mar 3, 2025
Merged

fix: usePullCompareTotalsTeam parsing error #3786

merged 1 commit into from
Mar 3, 2025

Conversation

nicholas-codecov
Copy link
Contributor

@nicholas-codecov nicholas-codecov commented Mar 3, 2025 •
edited
Loading

Description

This PR updates the Zod schema for usePullCompareTotalsTeam to set the patchCoverage field to be nullable

Ticket: codecov/engineering-team#3385

Notable Changes

  • Set patchCoverage to be nullable

@codecov Codecov
Copy link

codecov bot commented Mar 3, 2025

Bundle Report

Changes will increase total bundle size by 22 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.13MB 11 bytes (0.0%) ⬆️
gazebo-production-esm 6.2MB 11 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 11 bytes 113.05kB 0.01%

Files in assets/index-legacy.*.js:

  • ./src/services/pull/usePullCompareTotalsTeam.tsx → Total Size: 4.71kB
view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 11 bytes 125.63kB 0.01%

Files in assets/index.*.js:

  • ./src/services/pull/usePullCompareTotalsTeam.tsx → Total Size: 4.71kB

@codecov-staging
Copy link

codecov-staging bot commented Mar 3, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 22 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.13MB 11 bytes (0.0%) ⬆️
gazebo-staging-esm 6.2MB 11 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 11 bytes 113.05kB 0.01%

Files in assets/index-legacy.*.js:

  • ./src/services/pull/usePullCompareTotalsTeam.tsx → Total Size: 4.71kB
view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 11 bytes 125.63kB 0.01%

Files in assets/index.*.js:

  • ./src/services/pull/usePullCompareTotalsTeam.tsx → Total Size: 4.71kB

@codecov Codecov
Copy link

codecov bot commented Mar 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (cd34d55) to head (df4fc2a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3786   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         826      826           
  Lines       14947    14947           
  Branches     4256     4264    +8     
=======================================
  Hits        14759    14759           
  Misses        181      181           
  Partials        7        7
Files with missing lines Coverage Δ
src/services/pull/usePullCompareTotalsTeam.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.31% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd34d55...df4fc2a. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Mar 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3786   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         826      826           
  Lines       14947    14947           
  Branches     4264     4256    -8     
=======================================
  Hits        14759    14759           
  Misses        181      181           
  Partials        7        7
Files with missing lines Coverage Δ
src/services/pull/usePullCompareTotalsTeam.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.31% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd34d55...df4fc2a. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Mar 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (cd34d55) to head (df4fc2a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3786   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         826      826           
  Lines       14947    14947           
  Branches     4264     4256    -8     
=======================================
  Hits        14759    14759           
  Misses        181      181           
  Partials        7        7
Files with missing lines Coverage Δ
src/services/pull/usePullCompareTotalsTeam.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.31% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd34d55...df4fc2a. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Mar 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (cd34d55) to head (df4fc2a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3786   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         826      826           
  Lines       14947    14947           
  Branches     4264     4264           
=======================================
  Hits        14759    14759           
  Misses        181      181           
  Partials        7        7
Files with missing lines Coverage Δ
src/services/pull/usePullCompareTotalsTeam.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.31% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd34d55...df4fc2a. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
df4fc2a Mon, 03 Mar 2025 11:58:23 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Mar 3, 2025
Merged via the queue into main with commit 39c5c50 Mar 3, 2025
62 checks passed
@nicholas-codecov nicholas-codecov deleted the fix-usePullCompareTotalsTeam-parsing-errors branch March 3, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RulaKhaled RulaKhaled

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholas-codecov @codecov-releaser @RulaKhaled