feat: Setup Spotlight integration for local dev #3787
Conversation
Bundle ReportChanges will increase total bundle size by 6.12kB (0.05%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-esmAssets Changed:
Files in
view changes for bundle: gazebo-production-systemAssets Changed:
Files in
|
Bundle ReportChanges will increase total bundle size by 6.12kB (0.05%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3787 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 826 826
Lines 14947 14947
Branches 4256 4264 +8
=======================================
Hits 14759 14759
Misses 181 181
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3787 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 826 826
Lines 14947 14947
Branches 4256 4256
=======================================
Hits 14759 14759
Misses 181 181
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3787 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 826 826
Lines 14947 14947
Branches 4264 4264
=======================================
Hits 14759 14759
Misses 181 181
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3787 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 826 826
Lines 14947 14947
Branches 4256 4256
=======================================
Hits 14759 14759
Misses 181 181
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
| @@ -59,9 +59,15 @@ export default defineConfig((config) => { | |||
| return { | |||
| server: { | |||
| port: 3000, | |||
| headers: { | |||
There was a problem hiding this comment.
haven't worked with vite config before so just sanity checking: this doesn't end up in prod OR it does and we want it to, right?
There was a problem hiding this comment.
So this isn't a worry cause we don't use Vite, to serve anything in prod
There was a problem hiding this comment.
And if we did ... we'd want this value being set 😄
There was a problem hiding this comment.
Oh good point, a file being served can't add headers
There was a problem hiding this comment.
Based on your second comment, should we add this header to our file server config?
There was a problem hiding this comment.
That's been done for a hot minute, this was just something extra so we could collect profiling info in spotlight from a local instance
nicholas-codecov
deleted the
feat-setup-spotlight-integration-for-local-dev
branch
Description
Did some exploring with @BYK utilizing Spotlight, and since it was an easy add I thought I'd commit it, with some other updates for Sentry as well.
Notable Changes