Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add expanded redirect to App.tsx #3792

Merged
merged 5 commits into from
Mar 5, 2025
Merged

feat: Add expanded redirect to App.tsx #3792

merged 5 commits into from
Mar 5, 2025

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR updates the HomePageRedirect functionality to redirect to the to parameter to whatever value it is set to, other than plan, and will not redirect if the setup_action param is set.

Closes codecov/engineering-team#3450

Notable Changes

  • Conditionally redirect in the HomePageRedirect if to param is set
  • Add in tests

@nicholas-codecov nicholas-codecov changed the title feat: Add redirect to App.tsx feat: Add expanded redirect to App.tsx Mar 4, 2025
@codecov-staging
Copy link

codecov-staging bot commented Mar 4, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 151 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.12MB 71 bytes (0.0%) ⬆️
gazebo-staging-esm 6.19MB 80 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 80 bytes 638.8kB 0.01%

Files in assets/index.*.js:

  • ./src/App.tsx → Total Size: 8.75kB
view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 71 bytes 717.55kB 0.01%

Files in assets/index-legacy.*.js:

  • ./src/App.tsx → Total Size: 8.9kB

@codecov-qa
Copy link

codecov-qa bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (5e5329c) to head (cb91ef1).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3792   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         826      826           
  Lines       14948    14955    +7     
  Branches     4257     4259    +2     
=======================================
+ Hits        14760    14767    +7     
  Misses        181      181           
  Partials        7        7
Files with missing lines Coverage Δ
src/App.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.31% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e5329c...cb91ef1. Read the comment docs.

@codecov Codecov
Copy link

codecov bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (5e5329c) to head (cb91ef1).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3792   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         826      826           
  Lines       14948    14955    +7     
  Branches     4257     4267   +10     
=======================================
+ Hits        14760    14767    +7     
  Misses        181      181           
  Partials        7        7
Files with missing lines Coverage Δ
src/App.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.31% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e5329c...cb91ef1. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3792   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         826      826           
  Lines       14948    14955    +7     
  Branches     4257     4267   +10     
=======================================
+ Hits        14760    14767    +7     
  Misses        181      181           
  Partials        7        7
Files with missing lines Coverage Δ
src/App.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.31% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e5329c...cb91ef1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (5e5329c) to head (cb91ef1).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3792   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         826      826           
  Lines       14948    14955    +7     
  Branches     4257     4267   +10     
=======================================
+ Hits        14760    14767    +7     
  Misses        181      181           
  Partials        7        7
Files with missing lines Coverage Δ
src/App.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.31% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e5329c...cb91ef1. Read the comment docs.

@codecov Codecov
Copy link

codecov bot commented Mar 4, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 151 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.12MB 71 bytes (0.0%) ⬆️
gazebo-production-esm 6.19MB 80 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 80 bytes 638.8kB 0.01%

Files in assets/index.*.js:

  • ./src/App.tsx → Total Size: 8.75kB
view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 71 bytes 717.55kB 0.01%

Files in assets/index-legacy.*.js:

  • ./src/App.tsx → Total Size: 8.9kB

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Mar 4, 2025 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
1fa512a Tue, 04 Mar 2025 19:21:43 GMT Expired Expired
cb91ef1 Wed, 05 Mar 2025 11:13:24 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Mar 5, 2025
Merged via the queue into main with commit ba49650 Mar 5, 2025
62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-3450-add-redirect-in-app-tsx branch March 5, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalmurray-codecov spalmurray-codecov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Add redirect functionality in App
3 participants
@nicholas-codecov @codecov-releaser @spalmurray-codecov