Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include region when initializing storage #270

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: include region when initializing storage
the `api_archive.storage` module isn't pulling in the region as expected which causes the region to be ignored in some cases

this adds the region back similar to the `codecov-api` repo
  • Loading branch information
imnotjames authored Jun 30, 2024
commit 18ca01fed9a68571a31b68322ab00e5f877ac816
3 changes: 3 additions & 0 deletions shared/api_archive/storage.py
Original file line number Diff line number Diff line change
@@ -29,6 +29,8 @@ def __init__(self, in_config=None):
self.minio_config["iam_auth"] = False
if "iam_endpoint" not in self.minio_config:
self.minio_config["iam_endpoint"] = None
if "region" not in self.minio_config:
self.minio_config["region"] = None

if not MINIO_CLIENT:
MINIO_CLIENT = self.init_minio_client(
@@ -39,6 +41,7 @@ def __init__(self, in_config=None):
self.minio_config["verify_ssl"],
self.minio_config["iam_auth"],
self.minio_config["iam_endpoint"],
self.minio_config["region"],
)
log.info("----- created minio_client: ---- ")
self.minio_client = MINIO_CLIENT