Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UploadLevelTotalsFactory #343

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove UploadLevelTotalsFactory
This seems to be unused, and it should be removed along with `UploadLevelTotals`
  • Loading branch information
Swatinem committed Sep 2, 2024
commit 2d4b81d10abcec99dd7f0d7aea7dcdaec4df176c
23 changes: 0 additions & 23 deletions shared/django_apps/core/tests/factories.py
Original file line number Diff line number Diff line change
@@ -78,7 +78,6 @@ def _create(cls, model_class, *args, **kwargs):
ReportLevelTotalsFactory,
UploadFactory,
UploadFlagMembershipFactory,
UploadLevelTotalsFactory,
)

commit_report = CommitReportFactory(commit=commit)
@@ -129,17 +128,6 @@ def _create(cls, model_class, *args, **kwargs):
order_number=0,
storage_path="v4/raw/2019-01-10/4434BC2A2EC4FCA57F77B473D83F928C/abf6d4df662c47e32460020ab14abf9303581429/9ccc55a1-8b41-4bb1-a946-ee7a33a7fb56.txt",
)
UploadLevelTotalsFactory(
report_session=upload1,
files=3,
lines=20,
hits=17,
misses=3,
partials=0,
coverage=85.0,
branches=0,
methods=0,
)
UploadFlagMembershipFactory(
report_session=upload1,
flag=flag_unittests,
@@ -150,17 +138,6 @@ def _create(cls, model_class, *args, **kwargs):
order_number=1,
storage_path="v4/raw/2019-01-10/4434BC2A2EC4FCA57F77B473D83F928C/abf6d4df662c47e32460020ab14abf9303581429/9ccc55a1-8b41-4bb1-a946-ee7a33a7fb56.txt",
)
UploadLevelTotalsFactory(
report_session=upload2,
files=3,
lines=20,
hits=17,
misses=3,
partials=0,
coverage=85.0,
branches=0,
methods=0,
)
UploadFlagMembershipFactory(
report_session=upload2,
flag=flag_integrations,
7 changes: 0 additions & 7 deletions shared/django_apps/reports/tests/factories.py
Original file line number Diff line number Diff line change
@@ -69,13 +69,6 @@ class Meta:
files = factory.Faker("pyint")


class UploadLevelTotalsFactory(DjangoModelFactory):
class Meta:
model = models.UploadLevelTotals

report_session = factory.SubFactory(UploadFactory)


class ReportDetailsFactory(DjangoModelFactory):
class Meta:
model = models.ReportDetails
Loading
Oops, something went wrong.