Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Impact Analysis and Delete Tables #514

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove references to profiling tasks
  • Loading branch information
michelletran-codecov committed Feb 18, 2025
commit 726838d447542152433a023aafb7ba2c48ebc42c
31 changes: 0 additions & 31 deletions shared/celery_config.py
Original file line number Diff line number Diff line change
@@ -73,19 +73,6 @@
f"app.tasks.{TaskConfigGroup.commit_update.value}.CommitUpdate"
)

profiling_finding_task_name = (
f"app.cron.{TaskConfigGroup.profiling.value}.findinguncollected"
)
profiling_summarization_task_name = (
f"app.tasks.{TaskConfigGroup.profiling.value}.summarization"
)
profiling_collection_task_name = (
f"app.tasks.{TaskConfigGroup.profiling.value}.collection"
)
profiling_normalization_task_name = (
f"app.tasks.{TaskConfigGroup.profiling.value}.normalizer"
)

# Timeseries tasks
timeseries_backfill_task_name = f"app.tasks.{TaskConfigGroup.timeseries.value}.backfill"
timeseries_backfill_dataset_task_name = (
@@ -404,24 +391,6 @@ class BaseCeleryConfig(object):
default=task_default_queue,
)
},
f"app.tasks.{TaskConfigGroup.profiling.value}.*": {
"queue": get_config(
"setup",
"tasks",
TaskConfigGroup.profiling.value,
"queue",
default=task_default_queue,
)
},
f"app.cron.{TaskConfigGroup.profiling.value}.*": {
"queue": get_config(
"setup",
"tasks",
TaskConfigGroup.profiling.value,
"queue",
default=task_default_queue,
)
},
commit_update_task_name: {
"queue": get_config(
"setup",
1 change: 0 additions & 1 deletion shared/utils/enums.py
Original file line number Diff line number Diff line change
@@ -33,7 +33,6 @@ class TaskConfigGroup(Enum):
label_analysis = "label_analysis"
new_user_activated = "new_user_activated"
notify = "notify"
profiling = "profiling"
pulls = "pulls"
send_email = "send_email"
static_analysis = "static_analysis"
6 changes: 0 additions & 6 deletions tests/unit/test_celery_config.py
Original file line number Diff line number Diff line change
@@ -26,7 +26,6 @@ def test_celery_config():
assert hasattr(config, "worker_max_memory_per_child")
assert sorted(config.task_routes.keys()) == [
"app.cron.healthcheck.HealthCheckTask",
"app.cron.profiling.*",
"app.tasks.archive.*",
"app.tasks.cache_rollup.*",
"app.tasks.comment.Comment",
@@ -38,7 +37,6 @@ def test_celery_config():
"app.tasks.label_analysis.*",
"app.tasks.new_user_activated.NewUserActivated",
"app.tasks.notify.Notify",
"app.tasks.profiling.*",
"app.tasks.pulls.Sync",
"app.tasks.static_analysis.*",
"app.tasks.status.*",
@@ -68,7 +66,6 @@ def test_celery_config():
"task_name,task_group",
[
("app.cron.healthcheck.HealthCheckTask", TaskConfigGroup.healthcheck.value),
("app.cron.profiling.findinguncollected", TaskConfigGroup.profiling.value),
("app.tasks.comment.Comment", TaskConfigGroup.comment.value),
("app.tasks.commit_update.CommitUpdate", TaskConfigGroup.commit_update.value),
(
@@ -83,9 +80,6 @@ def test_celery_config():
TaskConfigGroup.new_user_activated.value,
),
("app.tasks.notify.Notify", TaskConfigGroup.notify.value),
("app.tasks.profiling.collection", TaskConfigGroup.profiling.value),
("app.tasks.profiling.normalizer", TaskConfigGroup.profiling.value),
("app.tasks.profiling.summarization", TaskConfigGroup.profiling.value),
("app.tasks.pulls.Sync", TaskConfigGroup.pulls.value),
("app.tasks.status.SetError", TaskConfigGroup.status.value),
("app.tasks.status.SetPending", TaskConfigGroup.status.value),