Log flag_pattern_matching usage
#524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is the `old` substring match behavior, and the new exact match one. We do get logs for mismatches, but usage of the old behavior depends on a config flag which we are not logging yet.
CodSpeed Performance ReportMerging #524 will create unknown performance changesComparing Summary
|
Swatinem
commented
Feb 24, 2025
| @@ -194,8 +196,15 @@ def _calculate_sessionids_to_include(self): | |||
| report_flags=sorted(self.report.flags.keys()), | |||
| ), | |||
| ) | |||
| if get_config("compatibility", "flag_pattern_matching", default=False): | |||
| return old_style_sessions | |||
| if get_config("compatibility", "flag_pattern_matching", default=False): | |||
There was a problem hiding this comment.
change in indentation is intended. previously we would check the flag and return old even if old == new.
giovanni-guidini
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is the
oldsubstring match behavior, and the new exact match one. We do get logs for mismatches, but usage of the old behavior depends on a config flag which we are not logging yet.