fix: remove storage service abstraction #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the goal of the storage service was to wrap the old minio storage service with 2 methods for creating and getting presigned urls. it did this by accessing the inner minio client of that service. i don't think we need this, we can instead have the minio storage and new minio storage services implement the same functionality and have that interface encoded as a new ABC. so this commit removes the storage service, creates a new ABC, inherits that ABC in the minio storage services, then has the archive service to use the minio storage services directly
CodSpeed Performance ReportMerging #530 will create unknown performance changesComparing Summary
|
Swatinem
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
lgtm. I hope we can further clean up all that stuff once we have this successfully rolled out.
Ideally we would merge this with the ArchiveService in worker to just have a single one, and also with a single storage backend (or two, the second one being MemoryStorage for testing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the goal of the storage service was to wrap the old minio storage service with 2 methods for creating and getting presigned urls. it did this by accessing the inner minio client of that service.
i don't think we need this, we can instead have the minio storage and new minio storage services implement the same functionality and have that interface encoded as a new ABC.
so this commit removes the storage service, creates a new ABC, inherits that ABC in the minio storage services, then has the archive service to use the minio storage services directly