Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create coverage data in monorepo-friendly way #532

Merged
merged 2 commits into from
Feb 27, 2025
Merged

create coverage data in monorepo-friendly way #532

merged 2 commits into from
Feb 27, 2025

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented Feb 24, 2025

needed for https://github.com/codecov/umbrella/pull/17

currently the docker image is built and coverage data is generated as if shared is its own repo and all the files are in the repo root. in umbrella that is no longer true - shared exists in libs/shared/ and we want that prefix to be applied to every source file we have data for

this PR sets up shared in /app/libs/shared instead of /app inside the docker container

Copy link

codspeed-hq bot commented Feb 24, 2025

CodSpeed Performance Report

Merging #532 will create unknown performance changes

Comparing pr532 (941a8ce) with main (fd58134)

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.\

@codecov-notifications
Copy link

codecov-notifications bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.51%. Comparing base (fd58134) to head (941a8ce).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #532   +/-   ##
=======================================
  Coverage   88.51%   88.51%           
=======================================
  Files         451      451           
  Lines       13127    13127           
  Branches     1529     1529           
=======================================
  Hits        11620    11620           
  Misses       1184     1184           
  Partials      323      323           
Flag Coverage Δ
shared-docker-uploader 88.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matt-codecov matt-codecov marked this pull request as draft February 27, 2025 17:49
@matt-codecov matt-codecov requested review from a team February 27, 2025 19:33
@matt-codecov matt-codecov marked this pull request as ready for review February 27, 2025 19:33
@matt-codecov matt-codecov added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit b49f475 Feb 27, 2025
12 checks passed
@matt-codecov matt-codecov deleted the pr532 branch February 27, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants