create coverage data in monorepo-friendly way #532
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed for https://github.com/codecov/umbrella/pull/17
currently the docker image is built and coverage data is generated as if
shared
is its own repo and all the files are in the repo root. inumbrella
that is no longer true -shared
exists inlibs/shared/
and we want that prefix to be applied to every source file we have data forthis PR sets up
shared
in/app/libs/shared
instead of/app
inside the docker containershared
, path fixing strips those extra directories off the path and nothing is different (see this PR's indirect changes for example - if paths were not the same we would see a bunch of "No data" entries)umbrella
, path fixing will strip/app
butlibs/shared
will remain like we want (see https://github.com/codecov/umbrella/pull/17 for example)