Make some benchmark code more explicit #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, this better highlights the difference between a shallow and a full parse of the Report. It also focuses the `totals` code a bit more, making the different operations more obvious. The filtering has also been slightly updated. As a driveby fix, this fixes the `Report.get(bind)` code, which was completely broken (because noone was using it?)
CodSpeed Performance ReportMerging #536 will create unknown performance changesComparing Summary
|
giovanni-guidini
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, this better highlights the difference between a shallow and a full parse of the Report.
It also focuses the
totalscode a bit more, making the different operations more obvious. The filtering has also been slightly updated.As a driveby fix, this fixes the
Report.get(bind)code, which was completely broken (because noone was using it?)