Set complexity/_total to None in diff calculation
#539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a recent regression from consolidating the diff calculation. Downstream code expects/asserts the `complexity/_total` to be `None` when no lines have been touched by the diff.
CodSpeed Performance ReportMerging #539 will create unknown performance changesComparing Summary
|
joseph-sentry
approved these changes
Feb 26, 2025
| @@ -97,4 +98,9 @@ def calculate_report_diff(report: AbstractReport, diff: RawDiff) -> CalculatedDi | |||
|
|
|||
| totals = sum_totals(list_of_file_totals) | |||
|
|
|||
| if totals.lines == 0: | |||
| totals = dataclasses.replace( | |||
There was a problem hiding this comment.
if there's a reason we're using dataclasses.replace instead of in place modifying the attrs of totals can you mention it in the PR description
There was a problem hiding this comment.
I haven’t really thought about this. I just restored the code as it existed before my refactor, so there is no functional change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a recent regression from consolidating the diff calculation. Downstream code expects/asserts the
complexity/_totalto beNonewhen no lines have been touched by the diff.