Make api_archive mockable again
#540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent change to the `api_archive.ArchiveService` meant that all the mocks that target `get_appropriate_storage_service` within `worker` stopped working. This fixes the mocking within `worker` by making sure that we always go through `get_appropriate_storage_service`.
CodSpeed Performance ReportMerging #540 will create unknown performance changesComparing Summary
|
joseph-sentry
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change to the
api_archive.ArchiveServicemeant that all the mocks that targetget_appropriate_storage_servicewithinworkerstopped working.This fixes the mocking within
workerby making sure that we always go throughget_appropriate_storage_service.