-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove usage of use_minio feature flag #542
Conversation
492b0a4
to
4160e9d
Compare
CodSpeed Performance ReportMerging #542 will create unknown performance changesComparing Summary
|
60130b9
to
015d76e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not yet correct. But lets goooo! 🎉
shared/storage/__init__.py
Outdated
if USE_MINIO.check_value(repoid, default=False): | ||
chosen_storage = "minio" | ||
|
||
if repoid and chosen_storage == "minio": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we are defaulting/hardcoding minio
now, you should rather remove the chosen_storage
check here. Or rather initializing it as minio
, independent of the get_config
and the force_minio
that I recently introduced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you suggesting doing
chosen_storage = "minio"
if repoid:
if USE_NEW_MINIO...
return _storage_service_cache...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, pretty much
this rollout is done and we are 100% enabled on prod so we are safe to remove this and simplify the logic starting off by removing all references to use_minio in shared
015d76e
to
ec4b5fb
Compare
❌ 3 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
❌ 3 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
❌ 3 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
❌ 3 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
this rollout is done and we are 100% enabled on prod so we are safe to remove this and simplify the logic
starting off by removing all references to use_minio in shared