Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove usage of use_minio feature flag #542

Closed
wants to merge 1 commit into from

Conversation

joseph-sentry
Copy link
Contributor

this rollout is done and we are 100% enabled on prod so we are safe to remove this and simplify the logic

starting off by removing all references to use_minio in shared

@joseph-sentry joseph-sentry requested a review from a team February 26, 2025 18:49
@joseph-sentry joseph-sentry force-pushed the joseph/remove-use-minio branch from 492b0a4 to 4160e9d Compare February 26, 2025 18:49
Copy link

codspeed-hq bot commented Feb 26, 2025

CodSpeed Performance Report

Merging #542 will create unknown performance changes

Comparing joseph/remove-use-minio (ec4b5fb) with main (fd58134)

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.\

@joseph-sentry joseph-sentry force-pushed the joseph/remove-use-minio branch 2 times, most recently from 60130b9 to 015d76e Compare February 26, 2025 19:15
Copy link
Contributor

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not yet correct. But lets goooo! 🎉

if USE_MINIO.check_value(repoid, default=False):
chosen_storage = "minio"

if repoid and chosen_storage == "minio":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are defaulting/hardcoding minio now, you should rather remove the chosen_storage check here. Or rather initializing it as minio, independent of the get_config and the force_minio that I recently introduced.

Copy link
Contributor Author

@joseph-sentry joseph-sentry Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you suggesting doing

chosen_storage = "minio"
if repoid:
  if USE_NEW_MINIO...
return _storage_service_cache...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, pretty much

this rollout is done and we are 100% enabled on prod so we are safe to
remove this and simplify the logic

starting off by removing all references to use_minio in shared
@joseph-sentry joseph-sentry force-pushed the joseph/remove-use-minio branch from 015d76e to ec4b5fb Compare February 27, 2025 17:02
Copy link

codecov bot commented Feb 27, 2025

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
1643 3 1640 1
View the top 3 failed test(s) by shortest run time
tests/unit/storage/test_init.py::TestStorageInitialization::test_get_appropriate_storage_service_aws
Stack Traces | 0.002s run time
self = <tests.unit.storage.test_init.TestStorageInitialization object at 0x7f91822d45f0>
mock_configuration = <shared.config.ConfigHelper object at 0x7f91808be5a0>

    def test_get_appropriate_storage_service_aws(self, mock_configuration):
        mock_configuration.params["services"] = {
            "chosen_storage": "aws",
            "gcp": gcp_config,
            "aws": aws_config,
        }
>       res = get_appropriate_storage_service()

.../unit/storage/test_init.py:91: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
shared/storage/__init__.py:25: in get_appropriate_storage_service
    _get_appropriate_storage_service_given_storage(chosen_storage)
shared/storage/__init__.py:39: in _get_appropriate_storage_service_given_storage
    return MinioStorageService(minio_config)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <shared.storage.minio.MinioStorageService object at 0x7f91808be1b0>
minio_config = {}

    def __init__(self, minio_config):
        self.minio_config = minio_config
        log.debug("Connecting to minio with config %s", self.minio_config)
    
        self.minio_client = self.init_minio_client(
>           self.minio_config["host"],
            self.minio_config.get("port"),
            self.minio_config["access_key_id"],
            self.minio_config["secret_access_key"],
            self.minio_config["verify_ssl"],
            self.minio_config.get("iam_auth", False),
            self.minio_config["iam_endpoint"],
            self.minio_config.get("region"),
        )
E       KeyError: 'host'

shared/storage/minio.py:40: KeyError
tests/unit/storage/test_init.py::TestStorageInitialization::test_get_appropriate_storage_service_gcp
Stack Traces | 0.002s run time
self = <tests.unit.storage.test_init.TestStorageInitialization object at 0x7f91822d4380>
mock_configuration = <shared.config.ConfigHelper object at 0x7f9180a188c0>

    def test_get_appropriate_storage_service_gcp(self, mock_configuration):
        mock_configuration.params["services"] = {
            "chosen_storage": "gcp",
            "gcp": gcp_config,
            "aws": aws_config,
        }
>       res = get_appropriate_storage_service()

.../unit/storage/test_init.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
shared/storage/__init__.py:25: in get_appropriate_storage_service
    _get_appropriate_storage_service_given_storage(chosen_storage)
shared/storage/__init__.py:39: in _get_appropriate_storage_service_given_storage
    return MinioStorageService(minio_config)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <shared.storage.minio.MinioStorageService object at 0x7f9180a198b0>
minio_config = {}

    def __init__(self, minio_config):
        self.minio_config = minio_config
        log.debug("Connecting to minio with config %s", self.minio_config)
    
        self.minio_client = self.init_minio_client(
>           self.minio_config["host"],
            self.minio_config.get("port"),
            self.minio_config["access_key_id"],
            self.minio_config["secret_access_key"],
            self.minio_config["verify_ssl"],
            self.minio_config.get("iam_auth", False),
            self.minio_config["iam_endpoint"],
            self.minio_config.get("region"),
        )
E       KeyError: 'host'

shared/storage/minio.py:40: KeyError
tests/unit/storage/test_init.py::TestStorageInitialization::test_get_appropriate_storage_service_fallback
Stack Traces | 0.003s run time
self = <tests.unit.storage.test_init.TestStorageInitialization object at 0x7f91822cea50>
mock_configuration = <shared.config.ConfigHelper object at 0x7f91805b5730>

    def test_get_appropriate_storage_service_fallback(self, mock_configuration):
        mock_configuration.params["services"] = {
            "chosen_storage": "gcp_with_fallback",
            "gcp": gcp_config,
            "aws": aws_config,
        }
>       res = get_appropriate_storage_service()

.../unit/storage/test_init.py:78: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
shared/storage/__init__.py:25: in get_appropriate_storage_service
    _get_appropriate_storage_service_given_storage(chosen_storage)
shared/storage/__init__.py:39: in _get_appropriate_storage_service_given_storage
    return MinioStorageService(minio_config)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <shared.storage.minio.MinioStorageService object at 0x7f917a960f80>
minio_config = {}

    def __init__(self, minio_config):
        self.minio_config = minio_config
        log.debug("Connecting to minio with config %s", self.minio_config)
    
        self.minio_client = self.init_minio_client(
>           self.minio_config["host"],
            self.minio_config.get("port"),
            self.minio_config["access_key_id"],
            self.minio_config["secret_access_key"],
            self.minio_config["verify_ssl"],
            self.minio_config.get("iam_auth", False),
            self.minio_config["iam_endpoint"],
            self.minio_config.get("region"),
        )
E       KeyError: 'host'

shared/storage/minio.py:40: KeyError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@codecov-staging
Copy link

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
1643 3 1640 1
View the top 3 failed test(s) by shortest run time
tests/unit/storage/test_init.py::TestStorageInitialization::test_get_appropriate_storage_service_aws
Stack Traces | 0.002s run time
self = <tests.unit.storage.test_init.TestStorageInitialization object at 0x7f91822d45f0>
mock_configuration = <shared.config.ConfigHelper object at 0x7f91808be5a0>

    def test_get_appropriate_storage_service_aws(self, mock_configuration):
        mock_configuration.params["services"] = {
            "chosen_storage": "aws",
            "gcp": gcp_config,
            "aws": aws_config,
        }
>       res = get_appropriate_storage_service()

.../unit/storage/test_init.py:91: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
shared/storage/__init__.py:25: in get_appropriate_storage_service
    _get_appropriate_storage_service_given_storage(chosen_storage)
shared/storage/__init__.py:39: in _get_appropriate_storage_service_given_storage
    return MinioStorageService(minio_config)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <shared.storage.minio.MinioStorageService object at 0x7f91808be1b0>
minio_config = {}

    def __init__(self, minio_config):
        self.minio_config = minio_config
        log.debug("Connecting to minio with config %s", self.minio_config)
    
        self.minio_client = self.init_minio_client(
>           self.minio_config["host"],
            self.minio_config.get("port"),
            self.minio_config["access_key_id"],
            self.minio_config["secret_access_key"],
            self.minio_config["verify_ssl"],
            self.minio_config.get("iam_auth", False),
            self.minio_config["iam_endpoint"],
            self.minio_config.get("region"),
        )
E       KeyError: 'host'

shared/storage/minio.py:40: KeyError
tests/unit/storage/test_init.py::TestStorageInitialization::test_get_appropriate_storage_service_gcp
Stack Traces | 0.002s run time
self = <tests.unit.storage.test_init.TestStorageInitialization object at 0x7f91822d4380>
mock_configuration = <shared.config.ConfigHelper object at 0x7f9180a188c0>

    def test_get_appropriate_storage_service_gcp(self, mock_configuration):
        mock_configuration.params["services"] = {
            "chosen_storage": "gcp",
            "gcp": gcp_config,
            "aws": aws_config,
        }
>       res = get_appropriate_storage_service()

.../unit/storage/test_init.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
shared/storage/__init__.py:25: in get_appropriate_storage_service
    _get_appropriate_storage_service_given_storage(chosen_storage)
shared/storage/__init__.py:39: in _get_appropriate_storage_service_given_storage
    return MinioStorageService(minio_config)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <shared.storage.minio.MinioStorageService object at 0x7f9180a198b0>
minio_config = {}

    def __init__(self, minio_config):
        self.minio_config = minio_config
        log.debug("Connecting to minio with config %s", self.minio_config)
    
        self.minio_client = self.init_minio_client(
>           self.minio_config["host"],
            self.minio_config.get("port"),
            self.minio_config["access_key_id"],
            self.minio_config["secret_access_key"],
            self.minio_config["verify_ssl"],
            self.minio_config.get("iam_auth", False),
            self.minio_config["iam_endpoint"],
            self.minio_config.get("region"),
        )
E       KeyError: 'host'

shared/storage/minio.py:40: KeyError
tests/unit/storage/test_init.py::TestStorageInitialization::test_get_appropriate_storage_service_fallback
Stack Traces | 0.003s run time
self = <tests.unit.storage.test_init.TestStorageInitialization object at 0x7f91822cea50>
mock_configuration = <shared.config.ConfigHelper object at 0x7f91805b5730>

    def test_get_appropriate_storage_service_fallback(self, mock_configuration):
        mock_configuration.params["services"] = {
            "chosen_storage": "gcp_with_fallback",
            "gcp": gcp_config,
            "aws": aws_config,
        }
>       res = get_appropriate_storage_service()

.../unit/storage/test_init.py:78: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
shared/storage/__init__.py:25: in get_appropriate_storage_service
    _get_appropriate_storage_service_given_storage(chosen_storage)
shared/storage/__init__.py:39: in _get_appropriate_storage_service_given_storage
    return MinioStorageService(minio_config)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <shared.storage.minio.MinioStorageService object at 0x7f917a960f80>
minio_config = {}

    def __init__(self, minio_config):
        self.minio_config = minio_config
        log.debug("Connecting to minio with config %s", self.minio_config)
    
        self.minio_client = self.init_minio_client(
>           self.minio_config["host"],
            self.minio_config.get("port"),
            self.minio_config["access_key_id"],
            self.minio_config["secret_access_key"],
            self.minio_config["verify_ssl"],
            self.minio_config.get("iam_auth", False),
            self.minio_config["iam_endpoint"],
            self.minio_config.get("region"),
        )
E       KeyError: 'host'

shared/storage/minio.py:40: KeyError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@codecov-qa
Copy link

codecov-qa bot commented Feb 27, 2025

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
1643 3 1640 1
View the top 3 failed test(s) by shortest run time
tests/unit/storage/test_init.py::TestStorageInitialization::test_get_appropriate_storage_service_aws
Stack Traces | 0.002s run time
self = <tests.unit.storage.test_init.TestStorageInitialization object at 0x7f91822d45f0>
mock_configuration = <shared.config.ConfigHelper object at 0x7f91808be5a0>

    def test_get_appropriate_storage_service_aws(self, mock_configuration):
        mock_configuration.params["services"] = {
            "chosen_storage": "aws",
            "gcp": gcp_config,
            "aws": aws_config,
        }
>       res = get_appropriate_storage_service()

.../unit/storage/test_init.py:91: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
shared/storage/__init__.py:25: in get_appropriate_storage_service
    _get_appropriate_storage_service_given_storage(chosen_storage)
shared/storage/__init__.py:39: in _get_appropriate_storage_service_given_storage
    return MinioStorageService(minio_config)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <shared.storage.minio.MinioStorageService object at 0x7f91808be1b0>
minio_config = {}

    def __init__(self, minio_config):
        self.minio_config = minio_config
        log.debug("Connecting to minio with config %s", self.minio_config)
    
        self.minio_client = self.init_minio_client(
>           self.minio_config["host"],
            self.minio_config.get("port"),
            self.minio_config["access_key_id"],
            self.minio_config["secret_access_key"],
            self.minio_config["verify_ssl"],
            self.minio_config.get("iam_auth", False),
            self.minio_config["iam_endpoint"],
            self.minio_config.get("region"),
        )
E       KeyError: 'host'

shared/storage/minio.py:40: KeyError
tests/unit/storage/test_init.py::TestStorageInitialization::test_get_appropriate_storage_service_gcp
Stack Traces | 0.002s run time
self = <tests.unit.storage.test_init.TestStorageInitialization object at 0x7f91822d4380>
mock_configuration = <shared.config.ConfigHelper object at 0x7f9180a188c0>

    def test_get_appropriate_storage_service_gcp(self, mock_configuration):
        mock_configuration.params["services"] = {
            "chosen_storage": "gcp",
            "gcp": gcp_config,
            "aws": aws_config,
        }
>       res = get_appropriate_storage_service()

.../unit/storage/test_init.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
shared/storage/__init__.py:25: in get_appropriate_storage_service
    _get_appropriate_storage_service_given_storage(chosen_storage)
shared/storage/__init__.py:39: in _get_appropriate_storage_service_given_storage
    return MinioStorageService(minio_config)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <shared.storage.minio.MinioStorageService object at 0x7f9180a198b0>
minio_config = {}

    def __init__(self, minio_config):
        self.minio_config = minio_config
        log.debug("Connecting to minio with config %s", self.minio_config)
    
        self.minio_client = self.init_minio_client(
>           self.minio_config["host"],
            self.minio_config.get("port"),
            self.minio_config["access_key_id"],
            self.minio_config["secret_access_key"],
            self.minio_config["verify_ssl"],
            self.minio_config.get("iam_auth", False),
            self.minio_config["iam_endpoint"],
            self.minio_config.get("region"),
        )
E       KeyError: 'host'

shared/storage/minio.py:40: KeyError
tests/unit/storage/test_init.py::TestStorageInitialization::test_get_appropriate_storage_service_fallback
Stack Traces | 0.003s run time
self = <tests.unit.storage.test_init.TestStorageInitialization object at 0x7f91822cea50>
mock_configuration = <shared.config.ConfigHelper object at 0x7f91805b5730>

    def test_get_appropriate_storage_service_fallback(self, mock_configuration):
        mock_configuration.params["services"] = {
            "chosen_storage": "gcp_with_fallback",
            "gcp": gcp_config,
            "aws": aws_config,
        }
>       res = get_appropriate_storage_service()

.../unit/storage/test_init.py:78: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
shared/storage/__init__.py:25: in get_appropriate_storage_service
    _get_appropriate_storage_service_given_storage(chosen_storage)
shared/storage/__init__.py:39: in _get_appropriate_storage_service_given_storage
    return MinioStorageService(minio_config)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <shared.storage.minio.MinioStorageService object at 0x7f917a960f80>
minio_config = {}

    def __init__(self, minio_config):
        self.minio_config = minio_config
        log.debug("Connecting to minio with config %s", self.minio_config)
    
        self.minio_client = self.init_minio_client(
>           self.minio_config["host"],
            self.minio_config.get("port"),
            self.minio_config["access_key_id"],
            self.minio_config["secret_access_key"],
            self.minio_config["verify_ssl"],
            self.minio_config.get("iam_auth", False),
            self.minio_config["iam_endpoint"],
            self.minio_config.get("region"),
        )
E       KeyError: 'host'

shared/storage/minio.py:40: KeyError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
1643 3 1640 1
View the top 3 failed tests by shortest run time
tests/unit/storage/test_init.py::TestStorageInitialization::test_get_appropriate_storage_service_aws
Stack Traces | 0.002s run time
self = <tests.unit.storage.test_init.TestStorageInitialization object at 0x7f91822d45f0>
mock_configuration = <shared.config.ConfigHelper object at 0x7f91808be5a0>

    def test_get_appropriate_storage_service_aws(self, mock_configuration):
        mock_configuration.params["services"] = {
            "chosen_storage": "aws",
            "gcp": gcp_config,
            "aws": aws_config,
        }
>       res = get_appropriate_storage_service()

.../unit/storage/test_init.py:91: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
shared/storage/__init__.py:25: in get_appropriate_storage_service
    _get_appropriate_storage_service_given_storage(chosen_storage)
shared/storage/__init__.py:39: in _get_appropriate_storage_service_given_storage
    return MinioStorageService(minio_config)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <shared.storage.minio.MinioStorageService object at 0x7f91808be1b0>
minio_config = {}

    def __init__(self, minio_config):
        self.minio_config = minio_config
        log.debug("Connecting to minio with config %s", self.minio_config)
    
        self.minio_client = self.init_minio_client(
>           self.minio_config["host"],
            self.minio_config.get("port"),
            self.minio_config["access_key_id"],
            self.minio_config["secret_access_key"],
            self.minio_config["verify_ssl"],
            self.minio_config.get("iam_auth", False),
            self.minio_config["iam_endpoint"],
            self.minio_config.get("region"),
        )
E       KeyError: 'host'

shared/storage/minio.py:40: KeyError
tests/unit/storage/test_init.py::TestStorageInitialization::test_get_appropriate_storage_service_gcp
Stack Traces | 0.002s run time
self = <tests.unit.storage.test_init.TestStorageInitialization object at 0x7f91822d4380>
mock_configuration = <shared.config.ConfigHelper object at 0x7f9180a188c0>

    def test_get_appropriate_storage_service_gcp(self, mock_configuration):
        mock_configuration.params["services"] = {
            "chosen_storage": "gcp",
            "gcp": gcp_config,
            "aws": aws_config,
        }
>       res = get_appropriate_storage_service()

.../unit/storage/test_init.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
shared/storage/__init__.py:25: in get_appropriate_storage_service
    _get_appropriate_storage_service_given_storage(chosen_storage)
shared/storage/__init__.py:39: in _get_appropriate_storage_service_given_storage
    return MinioStorageService(minio_config)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <shared.storage.minio.MinioStorageService object at 0x7f9180a198b0>
minio_config = {}

    def __init__(self, minio_config):
        self.minio_config = minio_config
        log.debug("Connecting to minio with config %s", self.minio_config)
    
        self.minio_client = self.init_minio_client(
>           self.minio_config["host"],
            self.minio_config.get("port"),
            self.minio_config["access_key_id"],
            self.minio_config["secret_access_key"],
            self.minio_config["verify_ssl"],
            self.minio_config.get("iam_auth", False),
            self.minio_config["iam_endpoint"],
            self.minio_config.get("region"),
        )
E       KeyError: 'host'

shared/storage/minio.py:40: KeyError
tests/unit/storage/test_init.py::TestStorageInitialization::test_get_appropriate_storage_service_fallback
Stack Traces | 0.003s run time
self = <tests.unit.storage.test_init.TestStorageInitialization object at 0x7f91822cea50>
mock_configuration = <shared.config.ConfigHelper object at 0x7f91805b5730>

    def test_get_appropriate_storage_service_fallback(self, mock_configuration):
        mock_configuration.params["services"] = {
            "chosen_storage": "gcp_with_fallback",
            "gcp": gcp_config,
            "aws": aws_config,
        }
>       res = get_appropriate_storage_service()

.../unit/storage/test_init.py:78: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
shared/storage/__init__.py:25: in get_appropriate_storage_service
    _get_appropriate_storage_service_given_storage(chosen_storage)
shared/storage/__init__.py:39: in _get_appropriate_storage_service_given_storage
    return MinioStorageService(minio_config)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <shared.storage.minio.MinioStorageService object at 0x7f917a960f80>
minio_config = {}

    def __init__(self, minio_config):
        self.minio_config = minio_config
        log.debug("Connecting to minio with config %s", self.minio_config)
    
        self.minio_client = self.init_minio_client(
>           self.minio_config["host"],
            self.minio_config.get("port"),
            self.minio_config["access_key_id"],
            self.minio_config["secret_access_key"],
            self.minio_config["verify_ssl"],
            self.minio_config.get("iam_auth", False),
            self.minio_config["iam_endpoint"],
            self.minio_config.get("region"),
        )
E       KeyError: 'host'

shared/storage/minio.py:40: KeyError

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants