-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ci: add fetch-depth: 2 to checkout step to fix codecov #545
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
=======================================
Coverage 88.51% 88.51%
=======================================
Files 451 451
Lines 13127 13127
Branches 1529 1529
=======================================
Hits 11620 11620
Misses 1184 1184
Partials 323 323
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #545 will create unknown performance changesComparing Summary
|
We recently chatted around the concept of "adapt our product so it works with the customers setup", vs "the customer has to update their CI/codebase to work with our product". The PR description is good, but I would like to better understand why we can’t just fix this case in the CLI, or server side for that matter? |
@Swatinem good idea, i mentioned it in codecov/engineering-team#3406
i think everyone that doesn't have |
github puts a merge commit at the top of every PR. the CLI is supposed to detect that and use the actual PR head as the SHA instead of the merge commit, but because we were missing this fetch-depth argument, the local checkout only had the merge commit in it.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.