fix: improve new minio implementation #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #546 +/- ##
==========================================
+ Coverage 88.50% 88.60% +0.09%
==========================================
Files 451 453 +2
Lines 13107 13044 -63
Branches 1528 1514 -14
==========================================
- Hits 11600 11557 -43
+ Misses 1184 1168 -16
+ Partials 323 319 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #546 will create unknown performance changesComparing Summary
|
joseph-sentry
force-pushed
the
joseph/improve-new-minio
branch
from
57ea96b to
87f3a30
Compare
Swatinem
reviewed
Feb 28, 2025
joseph-sentry
force-pushed
the
joseph/improve-new-minio
branch
2 times, most recently
from
e091208 to
1dbf739
Compare
this rollout is done and we are 100% enabled on prod so we are safe to remove this and simplify the logic starting off by removing all references to use_minio in shared
The team mentioned wanting to ship the new read implementation first then the new write implementation so this commit enables that. i'm folding the NewMinioStorageService functionality back into the MinioStorageService and creating 2 new feature flags one for read and one for write. Based on the values of those feature flags the MinioStorageService will choose an implementation of read/write. I also removed the old USE_NEW_MINIO feature flag, and modified the get_appropriate_storage_service function to make it so it no longer caches the MinioStorageService and instead the MinioStorageService is caching its internal minio_client since that is the expensive part of creating a new MinioStorageService instance. I also moved some code around
joseph-sentry
force-pushed
the
joseph/improve-new-minio
branch
from
1dbf739 to
2161274
Compare
Swatinem
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The team mentioned wanting to ship the new read implementation first
then the new write implementation so this commit enables that.
i'm folding the NewMinioStorageService functionality back into the
MinioStorageService and creating 2 new feature flags one for read and
one for write.
Based on the values of those feature flags the MinioStorageService
will choose an implementation of read/write.
I also removed the old USE_NEW_MINIO feature flag, and modified the
get_appropriate_storage_service function to make it so it no longer
caches the MinioStorageService and instead the MinioStorageService is
caching its internal minio_client since that is the expensive part
of creating a new MinioStorageService instance.
I also moved some code around