Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the python version, and uv.lock #547

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Swatinem
Copy link
Contributor

Bumps the .python-version to 3.13, and adds a required uv version as well, along with a uv sync that trims a bunch of python 3.12 wheel from the lockfile.

@Swatinem Swatinem requested a review from a team February 27, 2025 09:52
@Swatinem Swatinem self-assigned this Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.51%. Comparing base (fd58134) to head (e360bc1).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #547   +/-   ##
=======================================
  Coverage   88.51%   88.51%           
=======================================
  Files         451      451           
  Lines       13127    13127           
  Branches     1529     1529           
=======================================
  Hits        11620    11620           
  Misses       1184     1184           
  Partials      323      323           
Flag Coverage Δ
shared-docker-uploader 88.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@giovanni-guidini giovanni-guidini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will likely break the api build process that uses a python 3.12 image (see here)

Just something to keep in mind.

ps: I might be wrong, but the default arg for python image is ARG PYTHON_IMAGE=python:3.12-slim-bookworm

Bumps the `.python-version` to `3.13`, and adds a required `uv` version as well, along with a `uv sync` that trims a bunch of python 3.12 wheel from the lockfile.
@Swatinem Swatinem force-pushed the swatinem/upd-pyversion branch from af47b2f to e360bc1 Compare February 27, 2025 10:10
@Swatinem
Copy link
Contributor Author

Oh, that is a good point. I didn’t know that API was still on python 3.12, I thought we had updated to 3.13 all across the board.

On another note, this update broke the benchmark run (which does not work properly yet anyway), and it looks like I missed the following from https://docs.codspeed.io/benchmarks/python#usage-with-uv:

Using actions/setup-python to install python and not uv install is critical for tracing to work properly.

Copy link

codspeed-hq bot commented Feb 27, 2025

CodSpeed Performance Report

Merging #547 will create unknown performance changes

Comparing swatinem/upd-pyversion (e360bc1) with main (fd58134)

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.\

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants