-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the python version, and uv.lock
#547
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #547 +/- ##
=======================================
Coverage 88.51% 88.51%
=======================================
Files 451 451
Lines 13127 13127
Branches 1529 1529
=======================================
Hits 11620 11620
Misses 1184 1184
Partials 323 323
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will likely break the api build process that uses a python 3.12 image (see here)
Just something to keep in mind.
ps: I might be wrong, but the default arg for python image is ARG PYTHON_IMAGE=python:3.12-slim-bookworm
Bumps the `.python-version` to `3.13`, and adds a required `uv` version as well, along with a `uv sync` that trims a bunch of python 3.12 wheel from the lockfile.
af47b2f
to
e360bc1
Compare
Oh, that is a good point. I didn’t know that API was still on python 3.12, I thought we had updated to 3.13 all across the board. On another note, this update broke the benchmark run (which does not work properly yet anyway), and it looks like I missed the following from https://docs.codspeed.io/benchmarks/python#usage-with-uv:
|
CodSpeed Performance ReportMerging #547 will create unknown performance changesComparing Summary
|
Bumps the
.python-version
to3.13
, and adds a requireduv
version as well, along with auv sync
that trims a bunch of python 3.12 wheel from the lockfile.