Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid key-error when inserting asset chunks #550

Merged
merged 6 commits into from
Mar 3, 2025
Merged

fix: Avoid key-error when inserting asset chunks #550

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f8bb75d
if no key exists in map then skip
ajay-sentry Feb 28, 2025
829a5c5
actual fix
ajay-sentry Feb 28, 2025
32f2b93
add repr on asset for easier debugging, update jsons to v3 parser
ajay-sentry Feb 28, 2025
bcbb45e
fix tests, use .get()
ajay-sentry Feb 28, 2025
33e9f06
revert thing that makes test fail
ajay-sentry Feb 28, 2025
e97b3d9
add to other parser versions and test
ajay-sentry Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
actual fix
  • Loading branch information
@ajay-sentry
ajay-sentry committed Feb 28, 2025
commit 829a5c5da1b8ec25f4be9146bf7ecf0859fc541d
8 changes: 4 additions & 4 deletions shared/bundle_analysis/parsers/v3.py
View file
Original file line number Diff line number Diff line change
@@ -381,10 +381,13 @@ def _create_associations(self):
self.db_session.query(Asset)
.filter(
Asset.session_id == self.session.id,
Asset.asset_type == AssetType.JAVASCRIPT,
)
.all()
)

print("IN HERE")

asset_name_to_id = {asset.name: asset.id for asset in assets}

chunks: list[Chunk] = (
@@ -409,13 +412,10 @@ def _create_associations(self):
chunk_id = chunk.id
asset_names = self.chunk_asset_names_index[chunk.unique_external_id]

# Only add assets which we have references for in the asset_name_to_id map
# This is to avoid inserting assets for non-JS files
inserts.extend(
[
dict(asset_id=asset_name_to_id.get(asset_name), chunk_id=chunk_id)
dict(asset_id=asset_name_to_id[asset_name], chunk_id=chunk_id)
for asset_name in asset_names
if asset_name_to_id.get(asset_name) is not None
]
)
if inserts: